Repository navigation
fix: redirect unconfirmed password login to confirmation - #6
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
A correct password for an unconfirmed account now leads to the confirmation form with the email prefilled, giving the user a direct way to request another confirmation link. The account stays signed out until confirmation; opening the form does not send mail. Incorrect passwords still show the login error.
Related Issues
User-reported login flow; no tracker issue.
Type of Change
Checklist
[Unreleased]Validation:
bin/cipassed (155 tests, 348 assertions; 60 Ruby files lint clean). Six new controller/view tests cover the redirect, email prefill, no sign-in or mail, incorrect passwords, confirmed accounts, and confirmation-disabled accounts. The host Rails app's authentication integration suite also passed (19 tests, 148 assertions). Independent auth review found no actionable issues.