Repository navigation
Fix Patrol finding: rejected-rakeopt-leaves-a-stale-default-evaluati-906fca9b6852 - #1525
Closed
ivankuznetsov wants to merge 1 commit into
Closed
ivankuznetsov wants to merge 1 commit into
ivankuznetsov wants to merge 1 commit into
Conversation
…ected bin/hive-eval's inherited-RAKEOPT guard exited 1 before the shared stale-report removal point, so a previously valid report at tmp/hive-eval-report.json survived every RAKEOPT rejection (--dry-run, -n, or malformed values). Clear the default report on that path, matching the other pre-run guards; custom report paths are still only removed after full validation. The regression is wrapped in the reporter test's preserve_path helper so it restores a developer's pre-existing default report instead of clobbering the hardcoded checkout path, and the hive-eval report lifecycle contract in the wiki is updated with a log fragment.
2 of 3 tasks
Owner
Author
|
Merged as part of #1535, which batched the remaining ready PRs (including this PR's head) into one CI run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Patrol Fix
This pull request repairs one finding tracked by Hive's Patrol Fix workflow.
Sources
Finding evidence
Independent review
The patch fixes the stale default-report path at the rejected inherited-RAKEOPT guard, preserves custom-report behavior, and adds matching regression and wiki coverage. Focused verification is green; the controller full-suite failure is unrelated and caused by this checkout living under /tmp.
Validation
Verdict: failed