Skip to content

Fix Patrol finding: rejected-rakeopt-leaves-a-stale-default-evaluati-906fca9b6852 - #1525

Closed
ivankuznetsov wants to merge 1 commit into
mainfrom
hive/patrol-fix/rejected-rakeopt-leaves-a-stale-default-evaluati-906fca9b6852/g1
Closed

ivankuznetsov wants to merge 1 commit into
mainfrom
hive/patrol-fix/rejected-rakeopt-leaves-a-stale-default-evaluati-906fca9b6852/g1

Conversation

@ivankuznetsov

Copy link
Copy Markdown
Owner

Patrol Fix

This pull request repairs one finding tracked by Hive's Patrol Fix workflow.

Sources

  • ordinary_patrol: command-bin-hive-eval-20261009T000429Z-8a8fc3d8-1

Finding evidence

  • {"file":"bin/hive-eval","line":255,"snippet":"if inherited_rake_dry_run?(ENV["RAKEOPT"])","role":"trigger"}
  • {"file":"bin/hive-eval","line":257,"snippet":"exit 1","role":"root_cause"}
  • {"file":"bin/hive-eval","line":268,"snippet":"remove_report!(report_path)","role":"impact"}

Independent review

The patch fixes the stale default-report path at the rejected inherited-RAKEOPT guard, preserves custom-report behavior, and adds matching regression and wiki coverage. Focused verification is green; the controller full-suite failure is unrelated and caused by this checkout living under /tmp.

  • git diff fa96ebf 20252b2 adds default-only removal before the RAKEOPT rejection exit and no other runtime behavior.
  • The stale-default-report regression passed: 1 run, 12 assertions, 0 failures.
  • The full reporter suite passed: 39 runs, 320 assertions, 0 failures; RuboCop passed for both changed executable/test files; wiki_log_test passed: 7 runs, 27 assertions.
  • The independent adversarial fallback reported no findings, residual risks, or testing gaps.
  • The unrelated NewTest failure occurs at its precondition asserting that the checkout is outside Dir.tmpdir; this disposable checkout is under /tmp, before changed code is exercised.

Validation

Verdict: failed

  • ordinary:test: exit 1
  • agent:inherited-rakeopt-rejection-regression: exit 0
  • agent:full-reporter-eval-suite: exit 0
  • agent:rubocop-changed-files: exit 0

…ected

bin/hive-eval's inherited-RAKEOPT guard exited 1 before the shared
stale-report removal point, so a previously valid report at
tmp/hive-eval-report.json survived every RAKEOPT rejection (--dry-run,
-n, or malformed values). Clear the default report on that path, matching
the other pre-run guards; custom report paths are still only removed
after full validation.

The regression is wrapped in the reporter test's preserve_path helper so
it restores a developer's pre-existing default report instead of
clobbering the hardcoded checkout path, and the hive-eval report
lifecycle contract in the wiki is updated with a log fragment.
@ivankuznetsov

Copy link
Copy Markdown
Owner Author

Merged as part of #1535, which batched the remaining ready PRs (including this PR's head) into one CI run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant