Add transport k vs Sauter regression test#78
Open
krystophny wants to merge 8 commits into
Open
Conversation
Add compute_transport_k (k = 5/2 - D32/D31) to neo2_ql package and a regression test that compares NEO-2 k against gacode NEO Sauter reference on 2 AUG 30835 surfaces. Reference fixture lives in the private data repo (plasma/data) and is accessed via NEO2_DATA_DIR env var. CI workflow updated to use a project deploy token instead of a personal access token for cloning the data repo, and to checkout the matching branch before running the test. Closes #77
Move github.head_ref into env block instead of direct ${{ }}
interpolation in shell context. Remove redundant branch checkout
from golden record step since Clone test data already handles it.
Import from neo2_ql.transport_k instead of neo2_ql to avoid pulling in the full package init chain which requires scipy.
Inline the trivial formula in the test to avoid importing the full neo2_ql package which pulls in scipy (not declared as a dependency).
The data repo uses git LFS for all files. Add selective LFS pull for the transport_k fixture directory after checkout.
git lfs needs explicit credentials URL when using deploy tokens.
Deploy tokens don't support git LFS. Use personal access token (GITLAB_ACCESS_TOKEN) with oauth2 prefix which works for both git clone and LFS operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
compute_transport_k(d31, d32)toneo2_qlpackage (k = 5/2 - D32_ii / D31_ii)plasma/data, branchissue-77-transport-k-sauter-regression)GITLAB_DEPLOY_TOKEN/GITLAB_DEPLOY_USERsecrets, replaces expiredGITLAB_ACCESS_TOKEN)gacode_comparepackage and gacode NEO run outputs for provenanceNo private data exposed in this repo. Test skips gracefully when
NEO2_DATA_DIRis not set.Closes #77
Verification
Test passes locally with data
Test skips gracefully without data
CTest passes
Test plan
issue-77-transport-k-sauter-regressionbranch in data repo