Skip to content

fix(evaluators): preserve refinement validation across loky transport - #116

Merged
isty2e merged 2 commits into
mainfrom
fix/loky-refinement-transport
Sep 26, 2026
Merged

isty2e merged 2 commits into
mainfrom
fix/loky-refinement-transport

Conversation

@isty2e

@isty2e isty2e commented Sep 26, 2026

Copy link
Copy Markdown
Owner

Refinement-bearing local-search results could fail to deserialize when returned by Joblib's loky workers. The alignment cache stored candidate identities that pickle does not preserve for large integers or floats. Existing small-integer tests masked the failure.

Changes

  • Transport references to the validated request/refinement owners rather than raw candidate identities, without serializing equality callables.
  • Restore through the normal constructor. Stale owner references still require revalidation, and the coordinator independently checks alignment before assimilation.
  • Update the worker guide and evaluator contracts for development-version support, while retaining the threading workaround for 0.2.0.

Behavioral Evidence

A two-process CSA hill-climb run with candidates in [1000, 1100] now matches sequential execution in both per_request and worker_session modes, including candidate order, refinement provenance, evaluation costs, and final optimizer state.

Regression tests cover pickle protocols 4 and 5, large integers and floats, request-aligned payloads, replaced validation owners, invalid accounting, and coordinator rejection of mutated custom candidates. The guide examples also run with both loky transport modes.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 26, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-26T06:24:03.186021Z baf8886 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@isty2e
isty2e merged commit 90b79eb into main Sep 26, 2026
8 checks passed
@isty2e
isty2e deleted the fix/loky-refinement-transport branch September 26, 2026 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant