perf: reduce scalar distance validation overhead - #113
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
math.isfiniteafter the existingfloatnormalization in the scalar distance validatorPerformance
I ran three alternating parent/current smoke passes on the same machine, giving six samples per cell. Median zero-cost results:
The objective-only and legacy control paths varied by about 3% or less. At the 200 us objective band, every variopt path in the paired comparison also improved.
A separate 900-run full matrix covered both workloads, five objective-cost bands, three seeds, and five repeats. All 150 variopt semantic records matched the parent baseline exactly, including result and state digests, evaluation counts, proposal counts, generations, and failures.
Verification
uv run --extra test pytest: 1710 passeduv run --extra test pre-commit run --all-files: passed