perf: select profitable compiled distance views - #108
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
Encoded snapshots avoid repeated composite traversal, but they add projection and alignment work when the existing geometry is already direct. In a 30-repeat rotating comparison, the selected path reduced the continuous workload from 129.50 to 113.88 us/eval relative to forcing scalar encoding. The structured array workload remained faster with encoding enabled, at 222.03 versus 241.25 us/eval.
An additional shape sweep found the encoded permutation path 14-16% slower at sizes 2 and 8, while singleton array, tuple, and record candidates still benefited. Candidate, result, and state digests matched across every comparison.
Validation
uv run --extra test ruff check pyproject.toml src tests .github/scriptsuv run --extra test ruff format --check pyproject.toml src tests .github/scriptsuv run --extra test basedpyright src tests .github/scriptszuban checkon all changed Python filesuv run --extra test pytest tests -q(1607 passed)uv run --extra docs mkdocs build --strict