Repair ARM64 Linux release builds - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
renameat2throughSYS_renameat2instead of linking the optional glibc wrapper symbolRoot cause
The v0.4.0
aarch64-unknown-linux-gnurelease job compiled successfully but failed at link time because the cross image's glibc did not exportrenameat2. Calling the kernel syscall directly preservesRENAME_NOREPLACEsemantics without requiring that wrapper symbol.Compatibility
The public CLI and JSON protocol are unchanged. Linux still fails rather than falling back to a non-atomic check-then-rename when
renameat2is unavailable.Validation
cargo test --locked --bin identedit rename_file_no_replace_(2 passed on Linux)cargo fmt --checkcargo clippy --locked --all-targets -- -D warningscargo test --lockedcargo build --locked --releaseactionlintacross every workflowThe new GitHub-hosted ARM64 Linux job is the acceptance gate for the cross-link failure.