Refactor canonical edit intent ownership - #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preview.move.{from,to}dataeditandpatchflag mode through one private edit-intent model while preserving their distinct lifecyclesResponsibility map
changeset: owns canonical text-vs-move preview families and rejects missing, mixed, or legacy placeholder move previews at ingresscli::edit_intent: owns shared flag arguments, target selection, text-source resolution, and prepared intent normalizationcli::edit: resolves an intent and builds a changeset without writingcli::patch: resolves the same intent and executes apply/dry-run behaviorContract and compatibility
preview.movewith matchingfromandto; empty text placeholders and missing move preview data fail at ingress with a regeneration diagnosticedit --identityand patch's hidden--identity/--anchoraliases are removed;--atis the canonical selectoreditgains the same single-target flag capabilities aspatch, but remains build-onlypatchremains the one-shot apply path;--dry-runremains non-mutatingPublic graph and dependencies
cli::edit_intentownership and removed duplicatecli::patch::{flag,target,text}ownershipEditIntentArgs -> PreparedEditIntent -> edit build | patch executeLean decisions
Validation
cargo test --locked --all-targets --quiet(2,038 tests passed)cargo clippy --locked --all-targets -- -D warningscargo fmt --all -- --checkcargo build --locked --releasegit diff --check origin/main...HEADResidual risk
edit --identityflag or patch's hidden--identity/--anchoraliases must switch to--at