feat(pull-secret): add pull secret management commands#80
Open
benedictebn wants to merge 5 commits intomainfrom
Open
feat(pull-secret): add pull secret management commands#80benedictebn wants to merge 5 commits intomainfrom
benedictebn wants to merge 5 commits intomainfrom
Conversation
Contributor
|
Har patchet prosjektet siden du la inn denne. Trenger nok en rebase. La oss ta en runde og se over de nye kommandoene først vi merger. Si ifra når det er klart. |
benedictebn
force-pushed
the
feat/pull-secret-support
branch
from
32d6be3 to
0d2e5da
Compare
…tegration Add full CRUD support for image pull secrets (list, get, create, edit, delete), a cluster pull-secret set command, pull secret selection in the cluster create wizard, and pull secret display in cluster get output. Co-Authored-By: Claude Opus 4.6 <[email protected]>
- Fix line length by extracting endpoint variables - Fix cyclomatic complexity by extracting resolvePullSecretRef - Fix function length by extracting wizard helpers into wizard.go - Fix argument limit by using editOptions struct - Add yaml struct tags to PullSecret for musttag - Wrap FindPullSecretByName error for wrapcheck - Preallocate psOptions slice Co-Authored-By: Claude Opus 4.6 <[email protected]>
The Password field is a credential payload sent to the API, not a hardcoded secret. Co-Authored-By: Claude Opus 4.6 <[email protected]>
benedictebn
force-pushed
the
feat/pull-secret-support
branch
from
0d2e5da to
5145cf9
Compare
…mands Remove interactive wizard from create/edit commands and introduce a hierarchical `registry` subcommand group (add/remove) mirroring the teams member management pattern. Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
Co-Authored-By: Claude Sonnet 4.6 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #79
Summary
pull-secret list/get/create/delete)pull-secret registry add/removesubcommands to manage registries on an existing secret (mirrorsteam member add/removepattern)cluster pull-secret setcommand to assign a pull secret to a cluster--pull-secretflagcluster getoutputPullSecretClientinterface and REST methods to the platform clientImagePullSecretfield to theClusterstructTest plan
go build ./...compiles successfullygo test ./...all tests passgo vet ./...no issuesgolangci-lint runno issuesindev pull-secret create -n test-secret --address ghcr.io --username user --password passindev pull-secret listindev pull-secret get test-secretindev pull-secret registry add --pull-secret test-secret --address docker.io --username user --password passindev pull-secret registry remove --pull-secret test-secret --address docker.ioindev pull-secret delete test-secretindev cluster pull-secret set <cluster> <secret>indev cluster create --pull-secret <secret>indev cluster get <name>shows pull secret when assigned🤖 Generated with Claude Code