run_locally.sh: enable simulations with tc netem; add corresponding CI jobs for crdb/ybdb#1431
Open
mickmis wants to merge 1 commit intointeruss:mainfrom
Open
run_locally.sh: enable simulations with tc netem; add corresponding CI jobs for crdb/ybdb#1431mickmis wants to merge 1 commit intointeruss:mainfrom
mickmis wants to merge 1 commit intointeruss:mainfrom
Conversation
ce9e5fa to
2ded9f6
Compare
9e3aae7 to
6cf8430
Compare
mickmis
commented
Apr 27, 2026
|
|
||
| .PHONY: start-locally | ||
| start-locally: | ||
| build/dev/run_locally.sh up -d |
Contributor
Author
There was a problem hiding this comment.
--waitimplies-d- We need that for the ybdb deployment, as it is slower to be ready, and by the time the mocks are started and the uss_qualifier starts testing, the DSS is actually still not ready. Additionally it does IMO make sense for
make start-locallyto return once the stack is actually ready.
6cf8430 to
55b405c
Compare
…I jobs for crdb/ybdb
55b405c to
cb78ffa
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
make start-locallynow waits for the deployment to be ready before returningEvidence for CRDB:

