[SYCL][Driver][Test] Apply --no-offloadlib and -fno-sycl-instrument-device-code for 3 SYCL driver tests by jinge90 · Pull Request #23602 · intel/llvm

jinge90 · 2026-10-23T07:48:27Z

sycl-c-warn.c applies '--sysroot=%S/Inputs/SYCL --no-offloadlib', we don't need '--sysroot' if using '--no-offloadlib' to get rid of devicelibs. So, update the test to '--no-offloadlib -fno-sycl-instrument-device-code' to totally get rid of devicelibs.
sycl-allow-device-image-deps-win.cpp: every check is about the host link line, the devicelibs are not needed, so remove unnecessary sysroot and replace it with '--no-offloadlib -fno-sycl-instrument-device-code'.
sycl-offload.cpp: some lines are to test driver doesn't report error when target triple is valid 32-bit spir/v targets in new offload driver mode, all devicelibs only provide 64-bit version, so adding '--no-offloadlib and -fno-sycl-instrument-device-code' for these lines. We also apply no-offloadlib for adjacent lines for spir64 because these lines are to check target triple, devicelibs are not required, align spir32 with spir64 for the tests will not be confusing.

Signed-off-by: jinge90 <ge.jin@intel.com>

jinge90 · 2026-10-23T08:21:31Z

Hi, @intel/dpcpp-clang-driver-reviewers
Could you help review this PR?
Thanks very much.

jinge90 · 2026-10-27T02:09:00Z

Hi, @intel/dpcpp-clang-driver-reviewers
Could you help review this PR?
Thanks very much.

sys-ce-bb · 2026-10-27T03:12:49Z

@intel/llvm-gatekeepers please consider merging

jinge90 · 2026-10-27T05:37:06Z

Hi, @intel/llvm-gatekeepers
Could you help merge this PR?
Thanks very much.

…r_2_driver_tests

Signed-off-by: jinge90 <ge.jin@intel.com>

jinge90 · 2026-10-27T06:29:04Z

Hi, @srividya-sundaram
I applied '--no-offloadlib -fno-sycl-instrument-device-code' to sycl-offload.cpp in latest commit, the reason is some lines in the test are testing 32-bit spir/spirv target and all deivcelibs and incoming libc.bc only support 64-bit, so disable devicelibs for these lines in new offload driver to avoid error report.
Could you help review again?
Thanks very much.

Copilot

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

3 open issues

These modified RUN lines drop -ccc-install-dir %{clang_install_dir} while adjacent RUN lines in… · New
These modified RUN lines drop -ccc-install-dir %{clang_install_dir} while adjacent RUN lines in… · New
These modified RUN lines drop -ccc-install-dir %{clang_install_dir} while adjacent RUN lines in… · New

What changed in this PR

Updates several SYCL driver tests to avoid pulling in device libraries by using --no-offloadlib together with -fno-sycl-instrument-device-code, removing now-unnecessary --sysroot usage in these scenarios.

Changes:

Replace --sysroot=%S/Inputs/SYCL usage with --no-offloadlib -fno-sycl-instrument-device-code in targeted SYCL driver tests.
Adjust specific sycl-offload.cpp RUN lines (notably for 32-bit SPIR/SPIR-V target coverage) to avoid device library requirements.
Simplify Windows linker-dependency tests to focus on host link-line behavior without SYCL device libs.

File	Description
clang/test/Driver/sycl-offload.cpp	Adds `--no-offloadlib` + disables device instrumentation on select target-triple RUN lines to avoid device libs.
clang/test/Driver/sycl-c-warn.c	Drops SYCL sysroot dependency in warning test by relying on `--no-offloadlib` + disabling instrumentation.
clang/test/Driver/sycl-allow-device-image-deps-win.cpp	Removes SYCL sysroot dependency across link-line checks and uses `--no-offloadlib` + disabling instrumentation instead.

_{Review effort: Lite}


 /// Check no error for -fsycl-targets with good triple
-// RUN:   %clang -### -fsycl-targets=spir-unknown-unknown -fsycl --offload-new-driver -ccc-install-dir %{clang_install_dir}  %s 2>&1 \
+// RUN:   %clang -### -fsycl-targets=spir-unknown-unknown -fsycl --offload-new-driver --no-offloadlib -fno-sycl-instrument-device-code %s 2>&1 \


+// RUN:   %clang_cl -### -fsycl-targets=spir-unknown-unknown -fsycl --offload-new-driver --no-offloadlib -fno-sycl-instrument-device-code %s 2>&1 \
 // RUN:   | FileCheck -check-prefix=CHK-SYCL-TARGET %s
-// RUN:   %clang -### -fsycl-targets=spirv32-unknown-unknown -fsycl --offload-new-driver -ccc-install-dir %{clang_install_dir}  %s 2>&1 \
+// RUN:   %clang -### -fsycl-targets=spirv32-unknown-unknown -fsycl --offload-new-driver --no-offloadlib -fno-sycl-instrument-device-code %s 2>&1 \


 // RUN:   %clang -### -fsycl-targets=spirv64-unknown-unknown -fsycl --offload-new-driver -ccc-install-dir %{clang_install_dir}  %s 2>&1 \
 // RUN:   | FileCheck -check-prefix=CHK-SYCL-TARGET %s
-// RUN:   %clang -### -fsycl-targets=spirv32 -fsycl --offload-new-driver -ccc-install-dir %{clang_install_dir}  %s 2>&1 \
+// RUN:   %clang -### -fsycl-targets=spirv32 -fsycl --offload-new-driver --no-offloadlib -fno-sycl-instrument-device-code %s 2>&1 \


Signed-off-by: jinge90 <ge.jin@intel.com>

Copilot

Warning

Copilot couldn't run its full agentic review because it didn't start before the timeout. Make sure your repository has a runner available, or add a copilot-code-review.yml file specifying one with the runs-on attribute. See the docs for more details.

Copilot review overview

9 open issues

This file previously used /clang:--sysroot=%S/Inputs/SYCL on many %clang_cl invocations. Even… · New
This file previously used /clang:--sysroot=%S/Inputs/SYCL on many %clang_cl invocations. Even… · New
This file previously used /clang:--sysroot=%S/Inputs/SYCL on many %clang_cl invocations. Even… · New
These RUN lines also drop the sysroot entirely. If Inputs/SYCL was providing the minimal Windows… · New
These RUN lines also drop the sysroot entirely. If Inputs/SYCL was providing the minimal Windows… · New
These RUN lines drop -ccc-install-dir %{clang_install_dir} compared to the previous version, but… · New
These modified RUN lines drop -ccc-install-dir %{clang_install_dir} while adjacent RUN lines in…
These modified RUN lines drop -ccc-install-dir %{clang_install_dir} while adjacent RUN lines in…
These modified RUN lines drop -ccc-install-dir %{clang_install_dir} while adjacent RUN lines in…

_{Review effort: Lite}

jinge90 · 2026-10-27T07:49:09Z


 /// (1) Full path named directly as an input.
-// RUN: %clang_cl -fsycl /clang:--sysroot=%S/Inputs/SYCL \
+// RUN: %clang_cl -fsycl --no-offloadlib -fno-sycl-instrument-device-code \


The sysroot applied before is for locating dummy devicelibs, with '--no-offloadlib -fno-sycl-instrument-device-code', we don't need it anymore.


 /// (2) Full path passed through /link.
-// RUN: %clang_cl -fsycl /clang:--sysroot=%S/Inputs/SYCL \
+// RUN: %clang_cl -fsycl --no-offloadlib -fno-sycl-instrument-device-code \



 /// (4) Bare name via /link, resolved through the LIB env var.
-// RUN: env "LIB=%t.libdir" %clang_cl -fsycl /clang:--sysroot=%S/Inputs/SYCL \
+// RUN: env "LIB=%t.libdir" %clang_cl -fsycl --no-offloadlib -fno-sycl-instrument-device-code \


 // RUN: echo '#pragma comment(lib, "dep.lib")' > %t.dep.c
-// RUN: %clang_cl /clang:--sysroot=%S/Inputs/SYCL -c -o %t.dep.obj %t.dep.c
-// RUN: %clang_cl -fsycl /clang:--sysroot=%S/Inputs/SYCL \
+// RUN: %clang_cl -c -o %t.dep.obj %t.dep.c


 /// -fsycl-allow-device-image-dependencies without -fsycl.
-// RUN: %clang_cl /clang:--sysroot=%S/Inputs/SYCL \
-// RUN:          -fsycl-allow-device-image-dependencies /O2 -### %s \
+// RUN: %clang_cl -fsycl-allow-device-image-dependencies /O2 -### %s \


+// RUN:   %clang -### -fsycl-targets=spir-unknown-unknown -fsycl --offload-new-driver --no-offloadlib -fno-sycl-instrument-device-code %s 2>&1 \
 // RUN:   | FileCheck -check-prefix=CHK-SYCL-TARGET %s
-// RUN:   %clang -### -fsycl-targets=spir64 -fsycl --offload-new-driver -ccc-install-dir %{clang_install_dir}  %s 2>&1 \
+// RUN:   %clang -### -fsycl-targets=spir64 -fsycl --offload-new-driver --no-offloadlib -fno-sycl-instrument-device-code %s 2>&1 \
 // RUN:   | FileCheck -check-prefix=CHK-SYCL-TARGET %s
-// RUN:   %clang_cl -### -fsycl-targets=spir-unknown-unknown -fsycl --offload-new-driver -ccc-install-dir %{clang_install_dir}  %s 2>&1 \
+// RUN:   %clang_cl -### -fsycl-targets=spir-unknown-unknown -fsycl --offload-new-driver --no-offloadlib -fno-sycl-instrument-device-code %s 2>&1 \


jinge90 · 2026-10-28T02:10:48Z

Hi, @intel/llvm-gatekeepers
Could you help merge this PR? The failure in pre-ci is due to Window system hang and this PR only touches 3 driver lit tests, the pre-ci failure is for e2e test.

Thanks very much!

Apply no-offloadlib + no-sycl-instrument-device-code to replace sysroot

070618e

Signed-off-by: jinge90 <ge.jin@intel.com>

jinge90 requested a review from a team as a code owner October 23, 2026 07:48

srividya-sundaram approved these changes Oct 27, 2026

View reviewed changes

jinge90 added 2 commits October 27, 2026 14:15

Merge remote-tracking branch 'upstream/sycl' into apply_offloadlib_fo…

fe7d78b

…r_2_driver_tests

disable devicelibs for driver tests for 32-bit spir/v targets

c827e2b

Signed-off-by: jinge90 <ge.jin@intel.com>

jinge90 changed the title ~~[SYCL][Driver][Test] Apply --no-offloadlib and -fno-sycl-instrument-device-code for 2 SYCL driver tests~~ [SYCL][Driver][Test] Apply --no-offloadlib and -fno-sycl-instrument-device-code for 3 SYCL driver tests Oct 27, 2026

jinge90 requested a review from srividya-sundaram October 27, 2026 06:23

jinge90 requested a balanced review from Copilot October 27, 2026 06:37

Copilot AI reviewed Oct 27, 2026

View reviewed changes

align spir64 with spir32 for triple check

4797a27

Signed-off-by: jinge90 <ge.jin@intel.com>

jinge90 requested a balanced review from Copilot October 27, 2026 07:27

Copilot AI reviewed Oct 27, 2026

View reviewed changes

Copilot stopped reviewing on behalf of jinge90 due to an error October 27, 2026 09:39
The job was not acquired by a runner even after multiple attempts.

Copilot stopped reviewing on behalf of jinge90 due to an error October 27, 2026 10:11
Workflow completed but conclusion is not available. This may indicate rate limiting or API issues.

srividya-sundaram approved these changes Oct 28, 2026

View reviewed changes

jinge90 requested a review from a team October 28, 2026 02:09

sarnex merged commit c361723 into intel:sycl Oct 28, 2026
40 of 43 checks passed

Navigation Menu

Repository navigation

[SYCL][Driver][Test] Apply --no-offloadlib and -fno-sycl-instrument-device-code for 3 SYCL driver tests - #23602

[SYCL][Driver][Test] Apply --no-offloadlib and -fno-sycl-instrument-device-code for 3 SYCL driver tests#23602
sarnex merged 4 commits into
intel:syclfrom
jinge90:apply_offloadlib_for_2_driver_tests

jinge90 commented Oct 23, 2026 •

edited

Loading

Uh oh!

jinge90 commented Oct 23, 2026

Uh oh!

jinge90 commented Oct 27, 2026

Uh oh!

sys-ce-bb commented Oct 27, 2026

Uh oh!

jinge90 commented Oct 27, 2026

Uh oh!

jinge90 commented Oct 27, 2026 •

edited

Loading

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI left a comment

Uh oh!

jinge90 Oct 27, 2026

Uh oh!

jinge90 commented Oct 28, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

Conversation

jinge90 commented Oct 23, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jinge90 commented Oct 23, 2026

Uh oh!

jinge90 commented Oct 27, 2026

Uh oh!

sys-ce-bb commented Oct 27, 2026

Uh oh!

jinge90 commented Oct 27, 2026

Uh oh!

jinge90 commented Oct 27, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Copilot review overview

Uh oh!

jinge90 Oct 27, 2026

Choose a reason for hiding this comment

Uh oh!

jinge90 commented Oct 28, 2026

Uh oh!

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

jinge90 commented Oct 23, 2026 •

edited

Loading

jinge90 commented Oct 27, 2026 •

edited

Loading