Add RES-006 and RES-007 resource attribute rules#53
Draft
jpkrohling wants to merge 1 commit into
Draft
Conversation
Add two new instrumentation scoring rules based on OTel community resource attribute standards (community#2837): - RES-006: Validates service.criticality enum values (Normal impact) - RES-007: Checks deployment.environment.name presence (Important impact) Relates to OTEL-99. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
mmanciop
approved these changes
Apr 27, 2026
Contributor
|
I regret I only have one +1 to give |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two new instrumentation scoring rules based on OTel Service and Deployment Semantic Conventions (community#2837):
service.criticalityenum validation (mission_critical,high,medium,low) — Normal impactdeployment.environment.namepresence check — Important impactFuture work
Two additional rules are deferred until their semantic conventions are approved:
service.owner(Phase 1 — semconv not yet approved)data.sensitivity(Phase 3 — not yet defined in semconv)Test plan
Closes #54
🤖 Generated with Claude Code