Skip to content

Drop unreleased cacheFor functionality #795

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
skryukov wants to merge 2 commits into
base: 3.x
Choose a base branch
from
Open

Drop unreleased cacheFor functionality #795

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9bababa
Drop unreleased cacheFor functionality
skryukov Dec 10, 2025
be35c19
Merge branch '2.x' into pr/795
pascalbaljet Dec 10, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
44 changes: 0 additions & 44 deletions src/Response.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

namespace Inertia;

use Carbon\CarbonInterval;
use Closure;
use GuzzleHttp\Promise\PromiseInterface;
use Illuminate\Contracts\Support\Arrayable;
Expand Down Expand Up @@ -70,13 +69,6 @@ class Response implements Responsable
*/
protected $viewData = [];

/**
* The cache duration settings.
*
* @var array<int, mixed>
*/
protected $cacheFor = [];

/**
* The URL resolver callback.
*/
Expand Down Expand Up @@ -154,19 +146,6 @@ public function rootView(string $rootView): self
return $this;
}

/**
* Set the cache duration for the response.
*
* @param string|array<int, mixed> $cacheFor
* @return $this
*/
public function cache(string|array $cacheFor): self
{
$this->cacheFor = is_array($cacheFor) ? $cacheFor : [$cacheFor];

return $this;
}

/**
* Create an HTTP response that represents the object.
*
Expand All @@ -188,7 +167,6 @@ public function toResponse($request)
],
$this->resolveMergeProps($request),
$this->resolveDeferredProps($request),
$this->resolveCacheDirections($request),
$this->resolveScrollProps($request),
$this->resolveOnceProps($request),
);
Expand Down Expand Up @@ -456,28 +434,6 @@ public function resolvePropertyInstances(array $props, Request $request, ?string
return $props;
}

/**
* Resolve the cache directions for the response.
*
* @return array<string, mixed>
*/
public function resolveCacheDirections(Request $request): array
{
if (count($this->cacheFor) === 0) {
return [];
}

return [
'cache' => collect($this->cacheFor)->map(function ($value) {
if ($value instanceof CarbonInterval) {
return $value->totalSeconds;
}

return intval($value);
}),
];
}

/**
* Parse props from request headers.
*
Expand Down