Add a way to pick between the item and block atlas for materials that have both

[Ameliorate]

One solution might be to use Paper's new BlockType/ItemType APIs. For example, there'd be MaterialSprites.get(ItemType) which would default to the items atlas, and MaterialSprites.get(BlockType) that defaults to the block atlas.

I ask because I'm using this library for my custom crafting plugin. In the recipes list, I want to display the recipe's name and icons for its ingredients, but Bread displays its Wheat ingredient using Material.WHEAT's block form instead of its item form.

Thanks!

[indyteo]

Hi, thank you for raising this!

It's definitely something that could be improved, in fact I initially intended to give prevalence to the item form, but I broke this when I added exceptions for crops (in block form) by not realizing that wheat was using the same material for both item and block form.

While I like what you suggested, I don't really know how easily I could integrate it, because currently everything is based on the raw material. Furthermore, most materials have either a block form, or an item form, but rarely both. I wonder actually how many have both?
Maybe I should just fix the wheat manually, by removing its exact rule:

MaterialSpritesGenerator/src/main/java/fr/theoszanto/mc/materialspritesgenerator/MaterialSpritesGenerator.java

Line 158 in f9b94e6

rule().exact(Material.WHEAT).prepend(BLOCK).append("_stage7").sprite(),

That way, it would always take the item form, because it is the most suitable (even I you wanted to refer to the wheat crop block, e.g. "break 10 wheat", showing a wheat item will make it obvious to understand for the player, I think).

[Ameliorate]

Yeah you're right. Scrolling through the creative tabs, Wheat is seemingly the only instance of a Material that has a usable texture from both the blocks and items atlases. It'd probably be better to use wheat's item texture instead of complicating the API with the ability to select its block texture.