Skip to content

add chartPrefix to ids. Fixes #733#749

Closed
Jelmerovereem wants to merge 11 commits intoindiespirit:masterfrom
Jelmerovereem:master
Closed

add chartPrefix to ids. Fixes #733#749
Jelmerovereem wants to merge 11 commits intoindiespirit:masterfrom
Jelmerovereem:master

Conversation

@Jelmerovereem
Copy link
Copy Markdown

No description provided.

@iexitdev
Copy link
Copy Markdown
Contributor

Maintainer triage note: I would close this PR rather than merge it as-is.

The underlying SVG ID collision from #733 is a valid issue, but current master already has a per-chart gradient ID helper in AbstractChart/BarChart, so the useful part of this PR appears to be superseded. This branch also mixes in unrelated changes: deleting FUNDING.yml, adding Dependabot and CI workflows, upgrading TypeScript, changing the test command to --passWithNoTests, tsconfig changes, and a separate type tweak.

If #733 still reproduces on latest master, the best path would be a new focused PR containing only the remaining SVG ID fix.

@iexitdev iexitdev closed this Apr 27, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants