Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds support for passing lender action parameters (via EventData.CustomData) through the action service so outgoing ISO18626 SupplyingAgencyMessages can include fields like note, offeredCosts, and loanCondition.
Changes:
- Introduces
ActionParamsand decodesEventData.CustomDatainto it inhandleLenderAction. - Populates ISO18626
MessageInfo.Note,MessageInfo.OfferedCosts, andDeliveryInfo.LoanConditionfor selected lender actions. - Extends tests to pass
CustomDataand assert the resulting ISO18626 message contents.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| broker/patron_request/service/action.go | Parses action parameters from CustomData and includes them in outgoing SupplyingAgencyMessages (note/costs/loan condition). |
| broker/patron_request/service/action_test.go | Updates/extends lender action tests to supply CustomData and verify outgoing ISO18626 message fields. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://index-data.atlassian.net/browse/CROSSLINK-236