Skip to content

CROSSLINK-236 action params#496

Open
adamdickmeiss wants to merge 15 commits intomainfrom
CROSSLINK-236-action-params
Open

CROSSLINK-236 action params#496
adamdickmeiss wants to merge 15 commits intomainfrom
CROSSLINK-236-action-params

Conversation

@adamdickmeiss
Copy link
Copy Markdown
Contributor

@adamdickmeiss adamdickmeiss commented Mar 27, 2026

Copilot AI review requested due to automatic review settings March 27, 2026 15:04
@adamdickmeiss adamdickmeiss changed the title Crosslink 236 action params CROSSLINK-236 action params Mar 27, 2026
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds support for passing lender action parameters (via EventData.CustomData) through the action service so outgoing ISO18626 SupplyingAgencyMessages can include fields like note, offeredCosts, and loanCondition.

Changes:

  • Introduces ActionParams and decodes EventData.CustomData into it in handleLenderAction.
  • Populates ISO18626 MessageInfo.Note, MessageInfo.OfferedCosts, and DeliveryInfo.LoanCondition for selected lender actions.
  • Extends tests to pass CustomData and assert the resulting ISO18626 message contents.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.

File Description
broker/patron_request/service/action.go Parses action parameters from CustomData and includes them in outgoing SupplyingAgencyMessages (note/costs/loan condition).
broker/patron_request/service/action_test.go Updates/extends lender action tests to supply CustomData and verify outgoing ISO18626 message fields.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 5 comments.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated 4 comments.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 4 out of 4 changed files in this pull request and generated no new comments.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 9 out of 9 changed files in this pull request and generated no new comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants