fix(server): remove duplicate passwordAttemptLimiter declaration in rateLimiter.js#222
Open
Git-Shubham14 wants to merge 1 commit into
Open
Conversation
👷 Deploy request for file-sharingsystem pending review.Visit the deploys page to approve it
|
|
@Git-Shubham14 is attempting to deploy a commit to the imanchalsingh Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #215
server/middleware/rateLimiter.jsdeclaredpasswordAttemptLimitertwice usingexport const, causing aSyntaxError: Identifier 'passwordAttemptLimiter' has already been declaredcrash on every server startup.Root Cause
export const passwordAttemptLimiter = rateLimit({...})— correct declarationexport const passwordAttemptLimiter = rateLimit({...})— identical duplicate, accidentally addedJavaScript ESM does not allow two
constdeclarations with the same name in the same scope.Changes
server/middleware/rateLimiter.js— removed the second identical duplicate declaration ofpasswordAttemptLimiterat lines 57-68Type of Change
Checklist