Skip to content

docs: replace lenna image in docs#159

Merged
EscapedGibbon merged 5 commits into
mainfrom
156-losing-lena
Oct 1, 2025
Merged

docs: replace lenna image in docs#159
EscapedGibbon merged 5 commits into
mainfrom
156-losing-lena

Conversation

@EscapedGibbon

Copy link
Copy Markdown
Contributor

No description provided.

@EscapedGibbon EscapedGibbon linked an issue Oct 1, 2025 that may be closed by this pull request
@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Oct 1, 2025

Copy link
Copy Markdown

Deploying image-js-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 585ef94
Status: ✅  Deploy successful!
Preview URL: https://8aba5dbb.image-js-docs.pages.dev
Branch Preview URL: https://156-losing-lena.image-js-docs.pages.dev

View logs

@EscapedGibbon EscapedGibbon marked this pull request as ready for review October 1, 2025 09:16
@stropitek

stropitek commented Oct 1, 2025

Copy link
Copy Markdown
Contributor
CleanShot 2025-10-01 at 11 51 08@2x

Can you add resolution to image description?

For example Airport (1024px) and sort them from small to large?

Default image should be a small one.

@stropitek stropitek left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM if properly checked that there weren't any remaining references to lenna image.

@EscapedGibbon

EscapedGibbon commented Oct 1, 2025

Copy link
Copy Markdown
Contributor Author
CleanShot 2025-10-01 at 11 51 08@2x Can you add resolution to image description?

For example Airport (1024px) and sort them from small to large?

Default image should be a small one.

Can I do it like this: Airport (1024x1024)? Also, for the masks as well?

@stropitek

Copy link
Copy Markdown
Contributor

Can I do it like this: Airport (1024x1024)? Also, for the masks as well?

yes

@EscapedGibbon EscapedGibbon merged commit fa124c5 into main Oct 1, 2025
9 checks passed
@EscapedGibbon EscapedGibbon deleted the 156-losing-lena branch October 1, 2025 11:30
@tpoisseau

tpoisseau commented Oct 1, 2025

Copy link
Copy Markdown
Contributor

https://image-js-docs.pages.dev/docs/basics/working-with-masks

Sorry to answer lately, I suppose the issue comes from this PR:

Male and Airport images does not works in this page (and maybe some other pages)

CleanShot 2025-10-01 at 14 38 28@2x CleanShot 2025-10-01 at 14 38 44@2x

@EscapedGibbon

Copy link
Copy Markdown
Contributor Author

https://image-js-docs.pages.dev/docs/basics/working-with-masks

Sorry to answer lately, I suppose the issue comes from this PR:

Male and Airport images does not works in this page (and maybe some other pages)

CleanShot 2025-10-01 at 14 38 28@2x CleanShot 2025-10-01 at 14 38 44@2x

@tpoisseau thanks for pointing that out. I will create an issue about it.

@EscapedGibbon

Copy link
Copy Markdown
Contributor Author

Actually there is no need to create an issue here. It's an issue with dataset, since the problematic images were in "GRAY" colorModel. I will change images in the dataset with correct color model.

@EscapedGibbon

Copy link
Copy Markdown
Contributor Author

Fixed with this PR:
image-js/image-dataset-demo#3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Losing Lena

3 participants