Support confirmation for changing immutable commits - #720
Open
nikosavola wants to merge 4 commits into
Open
Conversation
nikosavola
force-pushed
the
nikosavola/push-xysqrouvwokx
branch
from
July 31, 2026 07:01
60f4e3b to
ac2e7e9
Compare
Shows a confirmation dialog offering to retry with --ignore-immutable whenever a jj command fails because the target commit is immutable, instead of requiring a per-action force keybinding (previously only edit had one).
nikosavola
force-pushed
the
nikosavola/push-xysqrouvwokx
branch
from
July 31, 2026 07:15
ac2e7e9 to
b3c4ddb
Compare
Contributor
|
This would be a significant improvement |
Owner
|
Hey thanks
What do you mean here? We have alt+enter which adss this flag automatically. |
Contributor
Author
I think my alt+enter has been bound to a shortcut to open a terminal split and I missed this... This PR offers a different way, I guess they could coexist but I understand if that seems unnecessary. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Right now only edit has a way to retry against an immutable commit (the alt+e force-edit binding). Everything else (split, describe, squash, rebase, ...) just fails with no way to recover short of leaving the TUI.
This adds a generic fix: when any jj command fails with jj's "commit is immutable" error, jjui pops up a confirmation dialog offering to retry the same command with --ignore-immutable.
command paths
fire it twice