Skip to content

Add verification case ver-1m#411

Open
f-griffin wants to merge 7 commits into
idaholab:develfrom
f-griffin:ZrH_Soret
Open

Add verification case ver-1m#411
f-griffin wants to merge 7 commits into
idaholab:develfrom
f-griffin:ZrH_Soret

Conversation

@f-griffin

Copy link
Copy Markdown

Add verification case ver-1m for steady state soret diffusion and conduction

(Ref. #383)

@simopier simopier self-assigned this Apr 22, 2026

@simopier simopier left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I see that you have some conflicts with the bib file.

You will want to run:

git fetch upstream && git rebase upstream/devel && git submodule update

and resolve the conflicts locally. What probably happened is that you added the references at the bottom of the files, and other people did too since you started your changes, and so now github is not sure what to do because the changes are not consistent.
One easy way to resolve that in the future is to put your references someone in the middle of the files - it's less likely that someone will add them there too.
For now, use the command above to update your local branch and it will tell you what files are conflicting, then you can open them in vscode and resolve the conflicts (make sure not to remove the references others added), then git add the updated files, and follow the directions, which will tell you to do git rebase --continue or something like that. It will open the commit file and you can just save it (:wq) and move on until your version is up to date and ready to be pushed agin.

@simopier simopier left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution @f-griffin!
This looks incredibly good for a first PR, well done!

I have some comments for you, you can find them here and add them to batch and commit them online.
Let me know if you run into any issues doing this.

The precheck tests are currently failing because you did not reference the issue number in your commits (see https://tmap8.inl.gov/getting_started/contributing.html for more information and guidance)
You'll need to add (Ref. #383) in one of your commit messages.

Let me know if you have any questions.

Comment thread doc/content/verification_and_validation/index.md Outdated
Comment thread doc/content/verification_and_validation/ver-1m.md Outdated
Comment thread doc/content/verification_and_validation/ver-1m.md Outdated
Comment thread doc/content/verification_and_validation/ver-1m.md Outdated

The material properties and case parameters are provided in [ver-1m_set_up_values].

!table id=ver-1m_set_up_values caption=Values of material properties and case geometry for the UZrH hydrogen migration verification problem.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given your note below the table, I recommend adding a Ref. columns to list the relevant reference [!cite](huang01102000) or state that it is an estimate.

Comment thread test/tests/ver-1m/ver-1m.i Outdated
Comment thread test/tests/ver-1m/ver-1m.i Outdated
Comment thread test/tests/ver-1m/ver-1m.i Outdated

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as in the input file here about temp vs temperature.

You will need to rename the output files too.

Comment thread test/tests/ver-1m/tests

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to make sure you have tests for all the csv files of interest. Here, you use the profiles mostly, so I recommend testing the profiles csv instead.
And make sure to remove all the csv files that are not tested from the gold folder.

You should be able to do

csvdiff = `filename_1.csv filename_2.csv`

@simopier

simopier commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Hi @f-griffin, do you have any questions about any of the comments I have left?
Let me know, I'm here to help!

@moosebuild

Copy link
Copy Markdown

Job Precheck, step Python: black format on ae84fe8 wanted to post the following:

Python black formatting

Your code requires style changes.

A patch was generated and copied here.

You can directly apply the patch by running the following at the top level of your repository:

curl -s https://mooseframework.inl.gov/tmap8/docs/PRs/411/black/black.patch | git apply -v

Alternatively, you can run the following at the top level of your repository:

black --config pyproject.toml --workers 1 .

@moosebuild

moosebuild commented Jun 15, 2026

Copy link
Copy Markdown

Job Documentation, step Sync to remote on d920571 wanted to post the following:

View the site here

This comment will be updated on new commits.

@moosebuild

moosebuild commented Jun 16, 2026

Copy link
Copy Markdown

Job Coverage, step Generate coverage on d920571 wanted to post the following:

Coverage

Coverage did not change

Full coverage report

This comment will be updated on new commits.

@moosebuild

Copy link
Copy Markdown

Job Build test summary, step Build test summary on d920571 wanted to post the following:

Test summary

Compared against a35a940 in job civet.inl.gov/job/3912142.

Added tests

Test Time (s) Memory (MB)
test:ver-1m.ver_1m_comparison 4.88 233.05
test:ver-1m.ver_1m_LHR_150_csvdiff 4.44 55.12
test:ver-1m.ver_1m_LHR_200_csvdiff 3.54 57.09
test:ver-1m.ver_1m_LHR_250_csvdiff 2.97 69.61
test:ver-1m.ver_1m_LHR_300_csvdiff 2.86 67.27

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants