[patch] DRO public route app added to gitops has broken GovCloud#425
Merged
tomklapiscak merged 7 commits intomainfrom Mar 27, 2026
Merged
[patch] DRO public route app added to gitops has broken GovCloud#425tomklapiscak merged 7 commits intomainfrom
tomklapiscak merged 7 commits intomainfrom
Conversation
tomklapiscak
approved these changes
Mar 27, 2026
Contributor
tomklapiscak
left a comment
There was a problem hiding this comment.
Verified that these changes resolve the issue in GovCloud
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue: MASCORE-13058
Description
Exposing DNS over public has some optional variables to be set. But the current implementation requires it to be mandatorily available. Added conditions to make them optional
Found this issue breaking both Govcloud and FVT
Testing
Tested in fvtsaas which doesn't have dro_public configured
