[patch] PostSync hook to rotate ECR token on install#423
Merged
tomklapiscak merged 3 commits intomainfrom Mar 27, 2026
Merged
Conversation
Template used to prevent code duplication Job verification scripts updated to inspect templates too
terenceq
approved these changes
Mar 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In GovCloud the ecr-token-updater_CronJob is responsible for periodically obtaining a short-lived ECR token and setting it in the cluster's global image pull secrets. Without this, the cluster will not be able to fetch images from the ECR mirror configured by the ImageDigestMirrorSet.
The problem is that the the CronJob is scheduled to run every 11 hours, and until this happens the cluster will not be able to pull any images. This breaks the install process until the CronJob has been run; bundle unpacking jobs will fail to run due to ImagePull errors.
The fix in this PR adds an additional one-time invocation of the ECR token rotation procedur when the image-mirroring application is synced during installation.
Template is used to prevent code duplication. Since this is the first definition of a Job resource inside a template, the
set-cli-image.digest.shandverify-job-definitions.shscripts have been updated to also inspect.tplfiles.Related Issue
https://jsw.ibm.com/browse/MASCORE-13057
Testing
Verified ecr-token-updater-init Job is now run when the image-mirroring application is synced, in addition to the regular cronjob: