Skip to content

Do not prepend siteaccess to URL if default#352

Open
pspanja wants to merge 1 commit intoibexa:5.0from
pspanja:default_siteaccess_uri
Open

Do not prepend siteaccess to URL if default#352
pspanja wants to merge 1 commit intoibexa:5.0from
pspanja:default_siteaccess_uri

Conversation

@pspanja
Copy link
Copy Markdown
Contributor

@pspanja pspanja commented Apr 9, 2024

🎫 Issue IBX-8088

Description:

If default siteaccess uses URI type matching, URL alias generated by passing default siteaccess explicitly will be different than when generated without passing it explicitly. Since in both cases the URL alias is generated for the same siteaccess, the result should be the same:

Example:

{{ path('ibexa.url.alias', {'contentId': content.id, 'siteaccess': 'default'}) }}

generates:

/default/some-alias

But:

{{ path('ibexa.url.alias', {'contentId': content.id}) }}

generates:

/some-alias

This adds the check that the matched siteaccess is default, in which case prepending of the siteaccess ID to the URL is skipped.

For QA:

Documentation:

@pspanja pspanja force-pushed the default_siteaccess_uri branch from 2822bcc to f8e939b Compare April 9, 2024 08:36
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Apr 9, 2024

Quality Gate Passed Quality Gate passed

Issues
1 New issue
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@sonarqubecloud
Copy link
Copy Markdown

@mnocon mnocon changed the base branch from main to 5.0 April 29, 2026 09:40
@mnocon
Copy link
Copy Markdown
Contributor

mnocon commented Apr 29, 2026

Hi! During the rename of main branch to 6.0, this PR was closed accidentally - I'm sorry about that.

I've reopened it, and set it to target the 5.0 branch - corresponding to the v5 version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants