Avoid implicit pointer sign conversion - #92
Open
michaelforney wants to merge 1 commit into
Open
Conversation
Pointer assignment and calls with pointer arguments require pointers to compatible types. Using the wrong sign is a constraint violation, since char and unsigned char are not compatible types. kb_entry.seq is always used with functions expecting char *, so make it a char * instead. Use an explicit conversion to char * when calling str* functions in posix_cclass().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pointer assignment and calls with pointer arguments require pointers
to compatible types. Using the wrong sign is a constraint violation,
since char and unsigned char are not compatible types.
kb_entry.seq is always used with functions expecting char *, so
make it a char * instead.
Use an explicit conversion to char * when calling str* functions
in posix_cclass().