Skip to content

fix!: CLI fixes before stable release - #239

Merged
PierreJeanjacquot merged 5 commits into
mainfrom
iapp-stable-cleanup
Sep 4, 2025
Merged

fix!: CLI fixes before stable release#239
PierreJeanjacquot merged 5 commits into
mainfrom
iapp-stable-cleanup

Conversation

@PierreJeanjacquot

@PierreJeanjacquot PierreJeanjacquot commented Sep 2, 2025

Copy link
Copy Markdown
Member

@github-actions

github-actions Bot commented Sep 2, 2025

Copy link
Copy Markdown

🐳 Hadolint Dockerfile Lint Results

Click to expand detailed results
api/Dockerfile:4 DL3018 warning: Pin versions in apk add. Instead of `apk add <package>` use `apk add <package>=<version>`

@PierreJeanjacquot
PierreJeanjacquot marked this pull request as ready for review September 3, 2025 10:13

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR performs small cleanup fixes to prepare for a stable release, making the signer parameter optional in utility functions and improving error handling consistency.

  • Made signer parameter optional in IExec utility functions to support read-only operations
  • Simplified variable naming by renaming "sconifiedImage" to "image" for clarity
  • Consolidated error handling by moving try-catch block to encompass the entire run function

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
cli/src/utils/tdx-poc.ts Made signer optional and added conditional provider connection logic
cli/src/utils/iexec.ts Made signer optional and added conditional provider connection logic
cli/src/utils/cacheExecutions.ts Renamed parameter from sconifiedImage to image for consistency
cli/src/cmd/run.ts Refactored function structure and moved error handling to main function
cli/src/cmd/deploy.ts Updated function call to use new image parameter name
api/src/constants/constants.ts Removed unused SCONE_NODE_IMAGE constant

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread cli/src/cmd/run.ts
Comment thread cli/src/cmd/run.ts Outdated
@PierreJeanjacquot PierreJeanjacquot changed the title Iapp stable cleanup fix!: CLI fix before stable release Sep 4, 2025
@PierreJeanjacquot PierreJeanjacquot changed the title fix!: CLI fix before stable release fix!: CLI fixes before stable release Sep 4, 2025

@abbesBenayache abbesBenayache left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@PierreJeanjacquot
PierreJeanjacquot merged commit 026fe1a into main Sep 4, 2025
8 of 9 checks passed
@PierreJeanjacquot
PierreJeanjacquot deleted the iapp-stable-cleanup branch September 4, 2025 08:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants