Fix gripper encoder wrap correction - #82
Draft
branyang02 wants to merge 2 commits into
Draft
Conversation
Move the replacement linear_4310 grasp point to 220 mm along flange-local -Z, align its axes with the UMI convention, and add FK/IK regression coverage.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Why
Linear grippers can legitimately travel beyond 2π radians. The existing startup loop applies its ±2π arm-encoder correction to every motor state, including the calibrated gripper. That changes the gripper motor offset while retaining the original calibration endpoints, putting feedback and commands in different coordinate frames.
This preserves the existing correction for arm joints while keeping calibrated gripper coordinates intact.
Validation
Not run yet at the operator's request because the robot is currently being used for another task. The regression test is included but has not been executed. No hardware, CAN interface, or robot process was accessed while preparing this change.