Use All-Args pattern instead of cast in updateConfigData#332
Open
DibyojyotiS wants to merge 3 commits intomainfrom
Open
Use All-Args pattern instead of cast in updateConfigData#332DibyojyotiS wants to merge 3 commits intomainfrom
DibyojyotiS wants to merge 3 commits intomainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #332 +/- ##
============================================
+ Coverage 75.64% 75.72% +0.07%
- Complexity 458 604 +146
============================================
Files 65 65
Lines 3039 3048 +9
Branches 149 149
============================================
+ Hits 2299 2308 +9
Misses 647 647
Partials 93 93
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Gg-harness
previously approved these changes
Feb 6, 2026
tim-mwangi
reviewed
Feb 6, 2026
...t-store/src/main/java/org/hypertrace/config/objectstore/IdentifiedObjectStoreWithFilter.java
Outdated
Show resolved
Hide resolved
tim-mwangi
previously approved these changes
Feb 6, 2026
8e921b2
tim-mwangi
approved these changes
Feb 6, 2026
tim-mwangi
left a comment
There was a problem hiding this comment.
Hopefully these parameters are arranged in the right order, especially the timestamps.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace cast to ContextualConfigObjectImpl with builder pattern that uses interface methods from ContextualConfigObject, fixes potential class cast exceptions when consumers override the getAllObjects method.