Skip to content

Use All-Args pattern instead of cast in updateConfigData#332

Open
DibyojyotiS wants to merge 3 commits intomainfrom
update-class-cast
Open

Use All-Args pattern instead of cast in updateConfigData#332
DibyojyotiS wants to merge 3 commits intomainfrom
update-class-cast

Conversation

@DibyojyotiS
Copy link
Contributor

Replace cast to ContextualConfigObjectImpl with builder pattern that uses interface methods from ContextualConfigObject, fixes potential class cast exceptions when consumers override the getAllObjects method.

@DibyojyotiS DibyojyotiS requested a review from a team as a code owner February 6, 2026 11:59
@codecov
Copy link

codecov bot commented Feb 6, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.72%. Comparing base (943e5ae) to head (1bc2aea).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #332      +/-   ##
============================================
+ Coverage     75.64%   75.72%   +0.07%     
- Complexity      458      604     +146     
============================================
  Files            65       65              
  Lines          3039     3048       +9     
  Branches        149      149              
============================================
+ Hits           2299     2308       +9     
  Misses          647      647              
  Partials         93       93              
Flag Coverage Δ
integration 75.72% <100.00%> (+0.07%) ⬆️
unit 73.74% <100.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions
Copy link

github-actions bot commented Feb 6, 2026

Test Results

151 tests  ±0   151 ✅ ±0   54s ⏱️ -3s
 31 suites ±0     0 💤 ±0 
 31 files   ±0     0 ❌ ±0 

Results for commit 22a580a. ± Comparison against base commit ca13e7b.

♻️ This comment has been updated with latest results.

Gg-harness
Gg-harness previously approved these changes Feb 6, 2026
tim-mwangi
tim-mwangi previously approved these changes Feb 6, 2026
@DibyojyotiS DibyojyotiS dismissed stale reviews from tim-mwangi and Gg-harness via 8e921b2 February 6, 2026 15:37
@DibyojyotiS DibyojyotiS changed the title Use builder pattern instead of cast in updateConfigData Use All-Args pattern instead of cast in updateConfigData Feb 6, 2026
Copy link

@tim-mwangi tim-mwangi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hopefully these parameters are arranged in the right order, especially the timestamps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants