chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest - #302
chore: fill derivable placeholders, drop false ARCHITECTURE, surface the rest#302hyperpolymath wants to merge 3 commits into
Conversation
…the rest
Estate top-up pass. Three separate things, none of which invents a value.
FILLED — every token with a single mechanical answer: OWNER, REPO, FORGE,
PROJECT, PACKAGE_NAME, PROJECT_NAME, AUTHOR, AUTHOR_EMAIL, CONDUCT_EMAIL,
AUTHOR_FIRST/LAST/INITIALS, CURRENT_YEAR, CURRENT_DATE, DATE, MAIN_BRANCH.
Identity comes from the git remote, dates from the clock, project name from the
README H1 where there is one.
Deliberately NOT filled, because more than one defensible answer exists and a
confident wrong value is worse than a visible gap: SECURITY_EMAIL (two competing
addresses are in use across the estate), RESPONSE_TIME, CONDUCT_TEAM (which
substitutes into "a {{CONDUCT_TEAM}} member", not English), WEBSITE,
PROJECT_DESCRIPTION, LANG_STACK.
DELETED — ARCHITECTURE.md, where it is byte-identical to the 346-copy estate
boilerplate (blob 607e3d8c). Those 33 lines describe a src/ tests/ docs/
scripts/ config/ tree that this repo does not have, so the file is not merely
uninformative, it is wrong. Genuinely written ARCHITECTURE files are matched by
hash and left alone. No file beats a confidently false one.
CODEOWNERS — rewritten to the solo form mandated by
hyperpolymath/standards CODEOWNERS-POLICY.adoc Rule 1, which forbids a catch-all
line where the only owner is the sole maintainer. The estate's own
templates/CODEOWNERS contradicts that policy; the policy is versioned, dated and
resolves standards#55, so it wins. Files naming a genuine co-owner are Rule 2
and are untouched. Note @hyperpolymath and @metadatastician are the same person,
so a file naming the other account is a copy artifact that silently routed
review requests to the wrong account.
SURFACED — REQUIRES_INITIALISATION.md, and a priority action in
0-AI-MANIFEST.a2ml. Tokens that need a decision no script can make are left
visibly unfilled rather than faked or quietly deleted. The marker says what each
one is, which files it belongs in, why it was not done already, and that it must
be deleted only once the work is genuinely finished.
|
|
||
| [methodology.state-validation] | ||
| reject-if-contains = ["{{PLACEHOLDER}}", "{{PROJECT}}", "rsr-template-repo"] | ||
| reject-if-contains = ["{{PLACEHOLDER}}", "BOJ_SERVER", "rsr-template-repo"] |
There was a problem hiding this comment.
⚠️ Bug: Placeholder substituted inside reject-if-contains breaks state validation
The top-up mechanically replaced the {{PROJECT}} token with BOJ_SERVER inside the reject-if-contains sentinel list. That list enumerates strings whose presence marks a STATE file as corrupt/template — {{PROJECT}} was itself a sentinel for an unfilled placeholder, not a value to fill. After this edit two things are wrong: (1) an unfilled {{PROJECT}} in a state file is no longer detected, and (2) any state referencing the legitimate BOJ_SERVER namespace (e.g. import BOJ_SERVER.ABI.Foreign, present in docs/ABI-FFI-README.adoc) is now falsely rejected. Restore the placeholder sentinel (e.g. {{PROJECT}}) rather than substituting the project constant here.
Keep the placeholder token as a sentinel; do not substitute it inside a detection rule.:
reject-if-contains = ["{{PLACEHOLDER}}", "{{PROJECT}}", "rsr-template-repo"]
- Apply fix
Check the box to apply the fix or reply for a change | Was this helpful? React with 👍 / 👎
| (protocol "https://github.com/hyperpolymath/0-ai-gatekeeper-protocol"))) | ||
|
|
||
| <!-- BEGIN requires-initialisation --> | ||
|
|
||
| ## PRIORITY ACTION — this repository is not fully initialised | ||
|
|
||
| 2 substitution token(s) still have no value. **Read | ||
| `REQUIRES_INITIALISATION.md` in the repository root before doing anything | ||
| else here** — it lists every outstanding token, what it means, and which | ||
| files it belongs in. | ||
|
|
||
| Do not fabricate values for them, and do not delete the sections that | ||
| contain them to quiet a gate. They are unfilled because they need a | ||
| decision, not because they were overlooked. Resolve what you legitimately | ||
| can, leave the rest, and delete `REQUIRES_INITIALISATION.md` only when |
There was a problem hiding this comment.
💡 Quality: Markdown/HTML appended after closed s-expression in a2ml manifest
0-AI-MANIFEST.a2ml is written as an s-expression form whose top-level (manifest …) closes at line 110, and comments in this grammar use ; (see the header). The appended block uses Markdown headings and HTML <!-- … --> comment markers, which are not valid s-expression comment syntax and sit after the closing paren of the sole top-level form. A strict a2ml/s-expression reader may fail to parse this file, which the header declares "MUST BE READ FIRST BY ALL AI AGENTS". Consider expressing the priority action as an s-expression form (or ;-prefixed comment) consistent with the rest of the file.
Was this helpful? React with 👍 / 👎
There was a problem hiding this comment.
Configure merge blocking · Maintainers can dismiss this review.
|
Note Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime. Code Review
|
| Compact |
|
Important
Your trial ends in 5 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.
Was this helpful? React with 👍 / 👎 | Gitar
…t a value
The estate top-up sweep substituted {{PROJECT}} here along with every other
token. This line is a DETECTOR list: the comment above it says these rules
detect corrupt/template/stale state files, so the tokens named in it are the
ones whose PRESENCE means a state file is broken.
Substituting it did two things. It blinded the {{PROJECT}} leak detector, and it
made the detector reject any state file containing this repo's own uppercased
name — the opposite of what the rule is for.
Same failure class as a template recipe rewriting the incident record that
documents its own bug: substituting tokens inside a thing that is ABOUT tokens.
Nothing else in this PR changes.
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The previous commit on this branch was written by a script that read the file through a shell command substitution. $(...) strips trailing newlines and printf '%s' does not put one back, so the file lost its final newline and the diff showed "\ No newline at end of file". Content is otherwise byte-identical to that commit. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Automated estate top-up. Nothing here invents a value.
Filled — every token with one mechanical answer (owner, repo, forge, author, dates, project name, main branch). Identity from the git remote, dates from the clock, name from the README H1.
Not filled, on purpose —
SECURITY_EMAIL(two competing addresses exist in the estate),RESPONSE_TIME,CONDUCT_TEAM(substitutes into "a {{CONDUCT_TEAM}} member", which is not English),WEBSITE,PROJECT_DESCRIPTION,LANG_STACK. More than one defensible answer exists, and a confident wrong value is worse than a visible gap.Deleted —
ARCHITECTURE.mdwhere it is byte-identical to the 346-copy estate boilerplate (blob607e3d8c). Those 33 lines describe asrc/ tests/ docs/ scripts/ config/tree this repo does not have. Matched by hash, so a genuinely written ARCHITECTURE can never be caught by it.CODEOWNERS — the solo form from
standards/CODEOWNERS-POLICY.adocRule 1, which forbids a catch-all where the only owner is the sole maintainer.templates/CODEOWNERScontradicts that policy; the policy is versioned, dated and resolvesstandards#55, so it wins. Genuine co-owners (Rule 2) are untouched.Surfaced —
REQUIRES_INITIALISATION.mdplus a priority action in0-AI-MANIFEST.a2ml, listing every remaining token, what it means, which files it belongs in, why it was not done already, and that it is to be deleted only when the work is genuinely complete.Built from a fresh clone of
origin/main, never a local checkout — several of those are dirty and hold unpushed commits.🤖 Generated with Claude Code