Skip to content

chore: land local compliance sweep + YAML repair - #299

Merged
hyperpolymath merged 3 commits into
mainfrom
chore/land-compliance-sweep
Aug 3, 2026
Merged

chore: land local compliance sweep + YAML repair#299
hyperpolymath merged 3 commits into
mainfrom
chore/land-compliance-sweep

Conversation

@hyperpolymath

Copy link
Copy Markdown
Owner

Lands three commits stranded on the local main (main is PR-only):

  • estate-wide security compliance (20dc1d7e): adds actions: read to workflow permission maps + GOVERNANCE.md content.
  • remove duplicate GOVERNANCE files (ba42404d): drops .github/GOVERNANCE.md in favor of root GOVERNANCE.md.
  • fix(ci): remove invalid actions: read under scalar permissions (f2b7cd1b): the sweep inserted an indented actions: read beneath permissions: read-all in 4 workflows (truthfulness, e2e, lsp-dap-bsp, container-publish) — invalid YAML that would parse-kill all four. Removed; read-all already implies it. All 26 workflows now pass a YAML parse check.

Note: a fourth local commit ("update guix.scm from squisher-corpus") was dropped — it was the known squisher-corpus guix.scm clobber (replaced the boj-server package definition with a generic squisher-corpus stub, source #f). The repo's real guix.scm is untouched by this PR.

🤖 Generated with Claude Code

hyperpolymath and others added 3 commits August 3, 2026 19:50
…flows)

The estate compliance sweep inserted an indented 'actions: read' beneath
'permissions: read-all', which is invalid YAML (scalar followed by mapping
continuation) and would parse-kill all four workflows. read-all already
grants actions:read, so removal is semantically neutral.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Comment thread .claude/worktrees/gov-red
@@ -0,0 +1 @@
Subproject commit 7add7bcac05ea4cb2fc0af62ec106dcd4779d73e
@@ -0,0 +1 @@
Subproject commit a1517a3677eed03e96e859d5aad0e957d5f156ac
@github-actions

github-actions Bot commented Aug 3, 2026

Copy link
Copy Markdown

🔍 Hypatia Security Scan

Findings: 246 issues detected

Severity Count
🔴 Critical 17
🟠 High 163
🟡 Medium 66

⚠️ Action Required: Critical security issues found!

View findings
[
  {
    "reason": "Issue in build.yml",
    "type": "missing_timeout_minutes",
    "file": "build.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in pages-deploy.yml",
    "type": "missing_timeout_minutes",
    "file": "pages-deploy.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in push-email-notify.yml",
    "type": "missing_timeout_minutes",
    "file": "push-email-notify.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "Issue in instant-sync.yml",
    "type": "secret_action_without_presence_gate",
    "file": "instant-sync.yml",
    "action": "peter-evans/repository-dispatch",
    "rule_module": "workflow_audit",
    "severity": "high"
  },
  {
    "reason": "Issue in codeql.yml",
    "type": "codeql_missing_actions_language",
    "file": "codeql.yml",
    "action": "flag",
    "rule_module": "workflow_audit",
    "severity": "medium"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/boj-server/boj-server/cartridges/academic-workflow-mcp/adapter/mod.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/boj-server/boj-server/cartridges/sanctify-mcp/adapter/mod.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/boj-server/boj-server/cartridges/bofig-mcp/adapter/mod.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/boj-server/boj-server/cartridges/ephapax-mcp/adapter/mod.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  },
  {
    "reason": "TypeScript file detected -- banned language",
    "type": "banned_language_file",
    "file": "/home/runner/work/boj-server/boj-server/cartridges/hesiod-mcp/adapter/mod.ts",
    "action": "flag",
    "rule_module": "cicd_rules",
    "severity": "critical"
  }
]

Powered by Hypatia Neurosymbolic CI/CD Intelligence

@gitar-bot

gitar-bot Bot commented Aug 3, 2026

Copy link
Copy Markdown

Note

Automatic reviews are paused because your trial's included automatic processing has been used for this period. Upgrade now, or comment "Gitar review" to run a review anytime.
Learn more

Code Review ✅ Approved

Lands estate-wide compliance updates, consolidates duplicate governance files, and fixes invalid YAML syntax across four CI workflows. No issues found.

Auto-approved and auto-merge armed: No blocking issues found.
Please see Auto-approve Docs for details on setting custom approval criteria. — merges when pipeline and required approvals pass.

Options

Display: compact → Showing less information.

Comment with these commands to change the behavior for this request:

Compact
gitar display:verbose         

Important

Your trial ends in 7 days — upgrade now to keep code review, CI analysis, auto-apply, custom automations, and more.

Was this helpful? React with 👍 / 👎 | Gitar

@gitar-bot
gitar-bot Bot enabled auto-merge (squash) August 3, 2026 18:56

@gitar-bot gitar-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Gitar has auto-approved this PR and enabled auto-merge (configure)

@gitar-bot gitar-bot Bot added the gitar-approved Added by Gitar label Aug 3, 2026
@hyperpolymath
hyperpolymath disabled auto-merge August 3, 2026 18:57
@hyperpolymath
hyperpolymath merged commit b3087bc into main Aug 3, 2026
50 of 52 checks passed
@hyperpolymath
hyperpolymath deleted the chore/land-compliance-sweep branch August 3, 2026 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

gitar-approved Added by Gitar

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants