feat: Set Button default variant to primary#1705
Merged
elizabetdev merged 1 commit intomainfrom Feb 5, 2026
Merged
Conversation
This change updates the Button component's default variant to "primary" in both the clickstack and hyperdx themes, ensuring a uniform appearance across the application.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 113bbcf The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
PR Review✅ No critical issues found. Notes:Impact Assessment:
Potential Consideration:
Consistency Check:
|
Contributor
E2E Test Results✅ All tests passed • 64 passed • 4 skipped • 783s
Tests ran across 4 shards in parallel. |
pulpdrew
approved these changes
Feb 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Sets the default Button variant to "primary" across both HyperDX and ClickStack themes, ensuring consistent button styling throughout the app.
Changes
defaultProps: { variant: 'primary' }to Button component in ClickStack themedefaultProps: { variant: 'primary' }to Button component in HyperDX themeMotivation
Previously, buttons without an explicit
variantprop would use Mantine's default styling. This change ensures all buttons default to the primary variant for a more consistent user experience, reducing the need to explicitly setvariant="primary"on every button.Screenshots
Test Plan