Skip to content

feat: Set Button default variant to primary#1705

Merged
elizabetdev merged 1 commit intomainfrom
fix/button-default-primary
Feb 5, 2026
Merged

feat: Set Button default variant to primary#1705
elizabetdev merged 1 commit intomainfrom
fix/button-default-primary

Conversation

@elizabetdev
Copy link
Contributor

Summary

Sets the default Button variant to "primary" across both HyperDX and ClickStack themes, ensuring consistent button styling throughout the app.

Changes

  • Added defaultProps: { variant: 'primary' } to Button component in ClickStack theme
  • Added defaultProps: { variant: 'primary' } to Button component in HyperDX theme

Motivation

Previously, buttons without an explicit variant prop would use Mantine's default styling. This change ensures all buttons default to the primary variant for a more consistent user experience, reducing the need to explicitly set variant="primary" on every button.

Screenshots

image

Test Plan

  • Verify buttons without variant prop now display with primary styling
  • Verify buttons with explicit variant props (secondary, danger) still work correctly
  • Test in both HyperDX and ClickStack themes

This change updates the Button component's default variant to "primary" in both the clickstack and hyperdx themes, ensuring a uniform appearance across the application.
@vercel
Copy link

vercel bot commented Feb 5, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
hyperdx-v2-oss-app Ready Ready Preview, Comment Feb 5, 2026 11:29am

Request Review

@changeset-bot
Copy link

changeset-bot bot commented Feb 5, 2026

🦋 Changeset detected

Latest commit: 113bbcf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@hyperdx/app Patch
@hyperdx/api Patch
@hyperdx/otel-collector Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@claude
Copy link

claude bot commented Feb 5, 2026

PR Review

No critical issues found.

Notes:

Impact Assessment:

  • The codebase already has explicit variant props on all existing Button components
  • This change sets a sensible default for future Button usages without breaking any existing code
  • ActionIcon already has variant: subtle as its default (lines 287-289 in hyperdx theme, 271-274 in clickstack theme)

Potential Consideration:

  • ⚠️ Two buttons use conditional variants that might benefit from review:

    • packages/app/src/components/ChartSQLPreview.tsx:38 - uses variant={copied ? "light" : "default"}
    • packages/app/src/components/TimePicker/TimePicker.tsx:338 - uses variant={value === item[0] ? "filled" : "subtle"}

    These still work correctly but now fallback to default behavior explicitly rather than Mantines implicit default.

Consistency Check:

  • ✅ Both themes (HyperDX and ClickStack) updated consistently
  • ✅ Changeset included properly
  • ✅ Follows established pattern (ActionIcon already uses defaultProps)

@github-actions
Copy link
Contributor

github-actions bot commented Feb 5, 2026

E2E Test Results

All tests passed • 64 passed • 4 skipped • 783s

Status Count
✅ Passed 64
❌ Failed 0
⚠️ Flaky 0
⏭️ Skipped 4

Tests ran across 4 shards in parallel.

View full report →

@elizabetdev elizabetdev merged commit 79356c4 into main Feb 5, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants