You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
❌ Inconsistent useLocalStorage API usage (DBSearchPage.tsx:855) → The custom useLocalStorage in utils.ts takes 2 positional params (key, initialValue), but AppNav.tsx uses Mantine's useLocalStorage with object param {key, defaultValue}. Line 855 uses positional params but mixes with variable default value - verify which useLocalStorage is imported and use consistent API.
⚠️Duplicate screen size calculation → isSmallScreen computed in both DBSearchPage.tsx (line 850) and AppNav.tsx (line 453) with same logic. This logic shouldn't be duplicated - consider extracting to shared hook or constant.
⚠️ActionIcon missing required variant (DBSearchPageFilters.tsx:1179, 1186) → Code style guide requires Button/ActionIcon to use variant="primary", variant="secondary", or variant="danger". The ActionIcons use variant="subtle" which is not in the allowed list. Change to appropriate custom variant.
Minor Notes:
The isFiltersCollapsed = isFiltersPreferCollapsed assignment (line 857) is unnecessary indirection - just use isFiltersPreferCollapsed directly throughout the component.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.