fix(Tooltip): skip delay race condition with multiple tooltips#2002
Open
AndersRobstad wants to merge 1 commit intohuntabyte:mainfrom
Open
fix(Tooltip): skip delay race condition with multiple tooltips#2002AndersRobstad wants to merge 1 commit intohuntabyte:mainfrom
AndersRobstad wants to merge 1 commit intohuntabyte:mainfrom
Conversation
When multiple tooltips share a provider, force-closing one tooltip to open another would unconditionally start the skip-delay timer. After the timer expired (default 300ms), `isOpenDelayed` reset to `true`, causing subsequent tooltip switches to require the full delay again. Move `#startTimer()` inside the `#openTooltip === tooltip` guard so the skip-delay timer only starts on genuine closes — not when a tooltip is force-closed because another one opened. Closes huntabyte#2001 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
Contributor
built with Refined Cloudflare Pages Action⚡ Cloudflare Pages Deployment
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
isOpenDelayedreset totrue, causing subsequent tooltip switches to require the fulldelayDurationagain instead of opening instantly#startTimer()inside the#openTooltip === tooltipguard so it only fires on genuine user-initiated closesCloses #2001
With the new implementation:
Skjermopptak.2026-03-27.kl.12.39.40.mov
With the old one:
Skjermopptak.2026-03-27.kl.12.40.37.mov