Repository navigation
Check the runner-key value itself; exempt input-shape asserts - #154
Merged
Merged
Conversation
Converted literals are drift-checked, a changed count of numbers and degenerate text (control characters, stutter) are rejected, a sign flip no longer hides an expectation-only patch, and asserts on the model's input shape are exempt from the runner-key rule.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #153. That check judged where a value went, not the value itself, so the red-flag PRs would pass it once reshaped onto
("cuda", 8). It also flagged a correct edit on the 2026-10-11 nightly.Expectationsblock, the runner value is compared against the literal it replaces. transformers#49243 (pvt_v2) moved 45% and skipped the check.\x04 A bus…) or a stutter (transformers#47983 starcoder2,def hello_world(): hello_world():). This isexpectation_guard.degenerate_text, which also feeds the guard's degenerate-value label._NUMBER_LITERALnow includes a unary minus. In the guard, #47698's-2.5104left a stray-, so the patch read as a code change and no expectation rule ran on it in prod.inputs.input_ids.shape == (2, 422). transformers#49507 (pegasus) was sent back 3 times and published with a wrong.shape/len(/.size(, so an output count is still checked.The exhausted-budget behaviour is unchanged: the PR still opens with the warning.
Checked against the real base/head files of transformers PRs:
("cuda", 8)(pvt_v2, starcoder2, fuyu, dab_detr)make test: 1404 passed.Ships on deploy (
TASK_EXPECTATION_KEY_CHECKstill switches it off).🤖 Generated with Claude Code