Repository navigation
fix(proxy): add trusted client attribution - #104
Merged
Merged
Conversation
Co-Authored-By: GPT-5.6 Sol <noreply@pi.dev> Generated-By: pi 0.84.2 (https://pi.dev)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Opened on behalf of Onur Solmaz (
osolmaz).Summary
OpenClaw
2026.8.1-beta.3requires a safe client attribution header for requests that arrive through a trusted proxy.MLClaw stripped the browser's forwarding headers but did not rebuild
x-forwarded-for, so GoEPT returned403 proxy_attribution_required.This change adds a server-owned attribution header for both HTTP and WebSocket traffic and prepares MLClaw
0.12.4.What Changed
The proxy still rejects all browser-supplied forwarding and OpenClaw headers.
After session validation, it now rebuilds
x-forwarded-forfrom the immediate Space ingress peer.192.0.2.1for loopback proxy traffic.Testing
The focused proxy test and the full local quality gate passed under Node.js 24.
npm test -- --run test/mlclaw.space-runtime.test.tsnpm run checkgit diff --checkRisks
MLClaw does not trust a browser-supplied client IP.
When the immediate ingress peer is loopback, OpenClaw sees a documentation-only address instead of the user's real network address; authenticated users share that attribution for rate limiting.