Skip to content

Fix TRL GRPO VLM example link - #367

Open
sergiopaniego wants to merge 2 commits into
mainfrom
fix-trl-example-paths
Open

Fix TRL GRPO VLM example link#367
sergiopaniego wants to merge 2 commits into
mainfrom
fix-trl-example-paths

Conversation

@sergiopaniego

Copy link
Copy Markdown
Member

Follow-up to huggingface/trl#6820: TRL's examples/ was reorganized into self-contained per-example folders, so links to the old examples/scripts/... paths will 404 once it merges. This updates them to the new locations. The link was also missing /blob/main, so it was already broken.

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@qgallouedec

Copy link
Copy Markdown
Member

Thanks! Small catch: huggingface/trl#6820 also renames the file after its folder, so the new link should be examples/grpo_visual_math/grpo_visual_math.py (not grpo_vlm.py), i.e. https://github.com/huggingface/trl/blob/main/examples/grpo_visual_math/grpo_visual_math.py

The reorg also renames each example's main file after its folder.
@HuggingFaceDocBuilderDev

Copy link
Copy Markdown

The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants