Skip to content

translation: Data Analyst agent into Korean - #212

Open
ahnjj wants to merge 5 commits into
huggingface:mainfrom
ahnjj:ko-agent_data_analyst.ipynb
Open

translation: Data Analyst agent into Korean#212
ahnjj wants to merge 5 commits into
huggingface:mainfrom
ahnjj:ko-agent_data_analyst.ipynb

Conversation

@ahnjj

@ahnjj ahnjj commented Oct 3, 2024

Copy link
Copy Markdown
Contributor

What does this PR do?

this is PR presents the korean translation of Data analyst agent: get your data’s insights in the blink of an eye ✨ cookbook.

Who can review?

@jeongiin, @harheem, @boyunJang, @ahnjj, @SeungAhSon,@jun048098,@win2dvp21

@review-notebook-app

Copy link
Copy Markdown

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@ahnjj
ahnjj marked this pull request as ready for review October 5, 2024 08:26
@merveenoyan

Copy link
Copy Markdown
Collaborator

@ahnjj 고맙습니다 once it's reviewed by another Korean speaker we can merge 🫰🏻

@jun048098

Copy link
Copy Markdown
Contributor

LGTM! 번역 감사합니다!

@merveenoyan

Copy link
Copy Markdown
Collaborator

@ahnjj we just merged a Korean recipe, toctree and index md has a merge conflict. Can you resolve it? We can merge afterwards.

Comment thread notebooks/ko/index.md Outdated
Comment thread notebooks/ko/_toctree.yml
@merveenoyan

Copy link
Copy Markdown
Collaborator

Sorry, another Korean recipe was merged, can you resolve again and we can merge this one
Also feel free to send a join request to this org.

Comment thread notebooks/ko/_toctree.yml
Comment thread notebooks/ko/index.md
@ahnjj

ahnjj commented Oct 27, 2024

Copy link
Copy Markdown
Contributor Author

Sorry, another Korean recipe was merged, can you resolve again and we can merge this one Also feel free to send a join request to this org.

Thank you for your help!
Since I've just resolved this, can you help with me to be merged?

Comment thread notebooks/ko/_toctree.yml Outdated
Comment thread notebooks/ko/_toctree.yml Outdated

@jun048098 jun048098 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM approve change

@merveenoyan

Copy link
Copy Markdown
Collaborator

@ahnjj if you can resolve the merge conflict we can merge
also don't forget to join this org: https://huggingface.co/huggingcooks

@ahnjj ahnjj closed this Mar 19, 2025
@ahnjj
ahnjj force-pushed the ko-agent_data_analyst.ipynb branch from d8dfa67 to 9cd571b Compare March 19, 2025 23:44
@ahnjj ahnjj reopened this Mar 19, 2025
@ahnjj

ahnjj commented Mar 19, 2025

Copy link
Copy Markdown
Contributor Author

@merveenoyan
Hi, sorry for the late modification!
I have resolved the conflict issue. If you could review this again and help with the merge, I would really appreciate it.

@ahnjj
ahnjj requested a review from jun048098 March 21, 2025 00:25
Comment thread notebooks/ko/_toctree.yml Outdated
@ahnjj

ahnjj commented Apr 1, 2025

Copy link
Copy Markdown
Contributor Author

Hey @merveenoyan , I’d love to get this translation merged.
This PR has been reviewed and is now awaiting review & approval with write access. Could you take a look when you have time? Let me know if any further changes are needed. Appreciate with your time!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants