Update TRL example paths after examples/ reorg - #3516
Conversation
|
Extended to the older posts too: |
pcuenca
left a comment
There was a problem hiding this comment.
Thanks for keeping them up to date!
|
Note for merging: this should land after huggingface/trl#6820 does (the new paths don't exist on TRL main until then). |
|
Thanks for the sweep! One catch: huggingface/trl#6820 also renames each example's main file after its folder, so 6 of the new links still 404 on the reorg branch:
The rest checks out, I validated every new link against the reorg-examples branch (the trl/scripts/sft.py retargets and the v1.10.0-pinned ones all resolve). |
The reorg also renames each example's main file after its folder, so the previous paths still 404. Also retargets the GOLD link to its new home in examples/gold_chatbot_arena/ instead of the v1.10.0 pin.
Follow-up to huggingface/trl#6820: TRL's
examples/was reorganized into self-contained per-example folders, so links to the oldexamples/scripts/...paths will 404 once it merges. This updates them to the new locations.