Validate TPU accelerate versions consistently - #4185
Open
lovettsendit wants to merge 3 commits into
Open
Conversation
Replace parse with try-except for version validation.
Add test for invalid accelerate version installation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Validate
--accelerate_versionwithpackaging.version.Versionand convert invalid input into a clear, stableValueError.Why
Accelerate supports
packaging>=20.0, butpackaging.version.parse()handles invalid versions differently across supported releases:InvalidVersion.As a result,
accelerate tpu-configcurrently accepts or rejects the same invalid value depending on the installed Packaging version.Validation
latest,dev, and explicit-version behavior remains unchanged.Discovered and reproduced with Breakcheck.