[Umbrella] Long-context SFT fixes (do not merge) - #4184
Draft
qgallouedec wants to merge 6 commits into
Draft
Conversation
…r inputs to pinned CPU memory
…ng-context-umbrella
|
The docs for this PR live here. All of your documentation changes will be reflected on that endpoint. The docs are available until 30 days after the last update. |
…te is never exchanged
…-fixes into long-context-umbrella
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Install-only umbrella for training on 1M+ token sequences: merges
activation_checkpointing_offload: offload checkpointed layer inputs to pinned CPU memory #4175 (FSDP2activation_checkpointing_offload)so colleagues can install one branch. Not meant to merge.
#4175 is what makes Qwen3-8B fit at 1,048,576 tokens on one 8xH100 node: without it the run OOMs. Paired with huggingface/transformers#48163 the step time is 373 s at 56.2 GB per GPU, against 582 s for Qwen3-4B (the largest that fits) on unmodified main.
Used by the 1M-token context-parallelism example in huggingface/trl#6846.