feat(runtime): add session_storage_mount_path to storage_config - #40
Open
jsuwuj wants to merge 4 commits into
Open
feat(runtime): add
session_storage_mount_path to storage_config#40jsuwuj wants to merge 4 commits into
jsuwuj wants to merge 4 commits into
Conversation
Add session_storage_mount_path field to StorageConfig, alongside sfs_turbo, so users can specify a session storage mount path in the container when creating/deploying a runtime.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #40 +/- ##
=======================================
Coverage ? 54.22%
=======================================
Files ? 95
Lines ? 7829
Branches ? 1209
=======================================
Hits ? 4245
Misses ? 3290
Partials ? 294 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…orage object
Replace flat string field session_storage_mount_path with
SessionStorageConfig model containing mount_path, serialized as
{"session_storage": {"mount_path": "..."}}.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary: Added
session_storage_mount_path to StorageConfig, rewrote to_dict(), fixed deploy.py pass-through,
updated init YAML. ## Test plan: 890 passed, 61 skipped, 0 failures. All skipped are gated
integration/E2E tests unrelated to this change.