Prevent #on_headers_complete callback from being called 2 times when parsing chunked requests#3
Open
HoneyryderChuck wants to merge 2 commits intohttp-parser:masterfrom
Open
Prevent #on_headers_complete callback from being called 2 times when parsing chunked requests#3HoneyryderChuck wants to merge 2 commits intohttp-parser:masterfrom
HoneyryderChuck wants to merge 2 commits intohttp-parser:masterfrom
Conversation
…chunk (this is triggering on headers callback two times)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Coming back from here and here.
Currently. the
#on_headers_completecallback is being fired 2 times when a request with chunked body is parsed. An example that demonstrates the issue can be found here.I've built against my fix locally and tested my ruby script, and it fixes the issue. I didn't add a java test, as the README doesn't tell me how can I setup the environment and run my tests, which is information I'd need before start doing something.