Always call on_message_begin for start_req_or_res #2
Open
atambo wants to merge 1 commit intohttp-parser:masterfrom
Open
Always call on_message_begin for start_req_or_res #2atambo wants to merge 1 commit intohttp-parser:masterfrom
atambo wants to merge 1 commit intohttp-parser:masterfrom
Conversation
|
@atambo good, but would you mind adding a test that fail the old code and pass with your pull request? |
Author
|
@flyerhzm, would you be able to get on the #jruby irc channel (https://github.com/jruby/jruby/wiki/IRC) and help me with the tests? I'm not understanding how the tests are setup. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This fixes basically all of the jruby https://github.com/tmm1/http_parser.rb test failures.