fix(comms): refactor wsdl generation to use minOccurs#4548
Open
jeclrsg wants to merge 1 commit intohpcc-systems:mainfrom
Open
fix(comms): refactor wsdl generation to use minOccurs#4548jeclrsg wants to merge 1 commit intohpcc-systems:mainfrom
jeclrsg wants to merge 1 commit intohpcc-systems:mainfrom
Conversation
There was a problem hiding this comment.
Pull request overview
Refactors the WSDL→TS generation utility to derive optional request/response fields from WSDL minOccurs="0" rather than making all request fields optional, and extends generated service endpoints to accept an optional abortSignal.
Changes:
- Added schema/node typing helpers and optional-field extraction based on
minOccurs. - Updated type-definition parsing to consult schema nodes (including inline complexTypes) and record optional properties per generated type.
- Updated generated service methods to accept
abortSignal?: AbortSignaland forward it to_connection.send(...).
* refactors the wsdl->ts generation utility to respect the "minOccurs" properties in WSDL definitions * exposes an optional "abortSignal" param to all service endpoints, so that consumers can define their own AbortSignals and they be passed thru to ESPConnection.send(...) * tightens up several instances of looser typing Signed-off-by: Jeremy Clements <79224539+jeclrsg@users.noreply.github.com>
68d31e2 to
6c7a90e
Compare
GordonSmith
requested changes
Mar 25, 2026
Member
GordonSmith
left a comment
There was a problem hiding this comment.
Shouldn't you regenerate all the stubs to ensure all the tests still pass?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist:
Testing: