Skip to content

fix(comms): refactor wsdl generation to use minOccurs#4548

Open
jeclrsg wants to merge 1 commit intohpcc-systems:mainfrom
jeclrsg:fix-comms-refactor-wsdl-generation
Open

fix(comms): refactor wsdl generation to use minOccurs#4548
jeclrsg wants to merge 1 commit intohpcc-systems:mainfrom
jeclrsg:fix-comms-refactor-wsdl-generation

Conversation

@jeclrsg
Copy link
Copy Markdown
Contributor

@jeclrsg jeclrsg commented Mar 23, 2026

  • refactors the wsdl->ts generation utility to respect the "minOccurs" properties in WSDL definitions
  • exposes an optional "abortSignal" param to all service endpoints, so that consumers can define their own AbortSignals and they be passed thru to ESPConnection.send(...)
  • tightens up several instances of looser typing

Checklist:

  • The commit message is properly formatted and free of typos.
    • The commit message title makes sense in a changelog, by itself.
    • The commit message includes a "fixes" reference if appropriate.
    • The commit is signed.
  • The change has been fully tested:
    • I have viewed all related gallery items
    • I have viewed all related dermatology items
  • There are no similar instances of the same problem that should be addressed
    • I have addressed them here
    • I have raised new issues to address them separately

Testing:

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Refactors the WSDL→TS generation utility to derive optional request/response fields from WSDL minOccurs="0" rather than making all request fields optional, and extends generated service endpoints to accept an optional abortSignal.

Changes:

  • Added schema/node typing helpers and optional-field extraction based on minOccurs.
  • Updated type-definition parsing to consult schema nodes (including inline complexTypes) and record optional properties per generated type.
  • Updated generated service methods to accept abortSignal?: AbortSignal and forward it to _connection.send(...).

* refactors the wsdl->ts generation utility to respect the "minOccurs"
  properties in WSDL definitions
* exposes an optional "abortSignal" param to all service endpoints, so
  that consumers can define their own AbortSignals and they be passed
  thru to ESPConnection.send(...)
* tightens up several instances of looser typing

Signed-off-by: Jeremy Clements <79224539+jeclrsg@users.noreply.github.com>
@jeclrsg jeclrsg force-pushed the fix-comms-refactor-wsdl-generation branch from 68d31e2 to 6c7a90e Compare March 23, 2026 17:26
@jeclrsg jeclrsg requested a review from GordonSmith March 23, 2026 17:26
Copy link
Copy Markdown
Member

@GordonSmith GordonSmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't you regenerate all the stubs to ensure all the tests still pass?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants