Skip to content

Animate Pikachu Up Tilt tail under Animation mode, add preview toggle, remove jumpsquat FX, and fix Mario SpecialN - #96

Merged
hopskipnfall merged 1 commit into
masterfrom
feature/pikachu-utilt-tail-animation
Sep 28, 2026
Merged

hopskipnfall merged 1 commit into
masterfrom
feature/pikachu-utilt-tail-animation

Conversation

@hopskipnfall

Copy link
Copy Markdown
Owner

Summary

  1. Pikachu Up Tilt Tail Animation (0x0c7):

    • Implemented dynamic overhead tail whip animation for Pikachu's Up Tilt when the Animation toggle is enabled (in both the Match View debug panel and Character Preview).
    • Tail rotation follows a fluid 27-frame eased arc (PIKACHU_UTIL_SWING_ANGLES_DEG): anticipation dip -> acceleration -> overhead whip crack (~+115 deg) on active hitbox frames 8–11 -> smooth return to rest.
    • Tail elongation scales along its length according to exact bytecode scale data from FTPikachuAnimUTilt.c (PIKACHU_UTIL_TAIL_SCALE), reaching 1.5x at frame 10 and smoothly returning to 1.0x by frame 14.
    • Symmetrically mirrored when facing left or right.
  2. Character Preview (/#/preview) Animation Toggle:

    • Added an Animation toggle button to the Frame Animation scrubber in the Character Preview controller.
    • State persists to localStorage ("rmgr-viewer-animation").
    • Added Pikachu's Up Tilt (0x0c7) to the state dropdown as visualized with its description.
  3. Remove Jumpsquat Ground FX:

    • Removed the ground pressure rings, lateral dust puffs, arrows, and kinetic spark effects (drawJumpSquatFx) during jump squat (0x014 / 0x015), leaving only the character model's subtle squat compression.
  4. Mario SpecialN (0xdf) Fireball Fix:

    • Fixed getMarioSpecialType to treat Mario's grounded 0xdf state as fireball (no coin / Up-B animation), showing the default avatar rather than Super Jump Punch coins.

Tests

  • Added unit tests in src/characters/original/pikachuUtiltAnimation.test.ts (11 tests).
  • Added unit tests in src/preview/characterPreview.test.ts for preview animation toggle.
  • Updated src/renderer.test.ts.
  • All tests pass (1439/1439 passed).
  • TypeScript check (npm run typecheck) and Prettier (npm run format:check) pass cleanly.

…, remove jumpsquat FX, and fix Mario SpecialN
@hopskipnfall
hopskipnfall merged commit 52e8a6a into master Sep 28, 2026
2 checks passed
@hopskipnfall
hopskipnfall deleted the feature/pikachu-utilt-tail-animation branch September 28, 2026 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant