Repository navigation
Animate Pikachu Up Tilt tail under Animation mode, add preview toggle, remove jumpsquat FX, and fix Mario SpecialN - #96
Merged
Conversation
…, remove jumpsquat FX, and fix Mario SpecialN
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Pikachu Up Tilt Tail Animation (
0x0c7):PIKACHU_UTIL_SWING_ANGLES_DEG): anticipation dip -> acceleration -> overhead whip crack (~+115 deg) on active hitbox frames 8–11 -> smooth return to rest.FTPikachuAnimUTilt.c(PIKACHU_UTIL_TAIL_SCALE), reaching1.5xat frame 10 and smoothly returning to1.0xby frame 14.Character Preview (
/#/preview) Animation Toggle:localStorage("rmgr-viewer-animation").0x0c7) to the state dropdown as visualized with its description.Remove Jumpsquat Ground FX:
drawJumpSquatFx) during jump squat (0x014/0x015), leaving only the character model's subtle squat compression.Mario SpecialN (
0xdf) Fireball Fix:getMarioSpecialTypeto treat Mario's grounded0xdfstate as fireball (no coin / Up-B animation), showing the default avatar rather than Super Jump Punch coins.Tests
src/characters/original/pikachuUtiltAnimation.test.ts(11 tests).src/preview/characterPreview.test.tsfor preview animation toggle.src/renderer.test.ts.npm run typecheck) and Prettier (npm run format:check) pass cleanly.