Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Advanced Run ID:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
zippy
force-pushed
the
security/navigation-lock
branch
from
September 24, 2026 18:13
f492d78 to
c66a1d2
Compare
zippy
force-pushed
the
security/linux-media-origin
branch
from
September 24, 2026 18:13
19abe73 to
9984894
Compare
zippy
marked this pull request as ready for review
September 25, 2026 14:38
mattyg
previously approved these changes
Sep 28, 2026
zippy
force-pushed
the
security/navigation-lock
branch
from
September 30, 2026 15:22
fd6d87d to
c4ca0a1
Compare
zippy
force-pushed
the
security/navigation-lock
branch
from
September 30, 2026 15:35
c4ca0a1 to
162aea0
Compare
Answer each WebKitGTK user-media permission request against the origin the webview first loaded, and deny it for any other page, instead of granting media capture to every webview.
zippy
force-pushed
the
security/linux-media-origin
branch
from
September 30, 2026 18:28
9984894 to
bc005f8
Compare
|
✔️ bc005f8 - Conventional commits check succeeded. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
On Linux the plugin used to grant WebKitGTK camera and microphone requests on every webview. It now answers each request against the origin the webview first loaded, using the record from the navigation lock, and denies any page on another origin. Plugin-built windows cannot leave their origin anyway, so this mainly covers windows an app builds itself.
TODO:
npm run cipasses