Skip to content

use aws_s3_object #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nmnielsen wants to merge 3 commits into
base: master
Choose a base branch
from
Open

use aws_s3_object #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f455930
use aws_s3_object
nmnielsen Nov 16, 2025
48f07ef
terraform 1.7.4
nmnielsen Nov 16, 2025
ceb8117
tf format
nmnielsen Nov 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/checks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
- uses: actions/checkout@master
- uses: hashicorp/setup-terraform@v1
with:
terraform_version: 1.3.0
terraform_version: 1.7.4
- id: Init
run: terraform init -no-color
- id: Fmt
Expand Down
16 changes: 8 additions & 8 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,12 +51,12 @@ resource "aws_iam_role_policy_attachment" "lambda_insights" {
}

# S3 object to hold the deployed artifact
resource "aws_s3_bucket_object" "lambda_deploy_object" {
count = var.image_uri == null ? 1 : 0
bucket = local.deployment_bucket_id
key = "${var.name}/${local.deploy_artifact_key}"
source = var.path
source_hash = md5(local.source_hash)
resource "aws_s3_object" "lambda_deploy_object" {
count = var.image_uri == null ? 1 : 0
bucket = local.deployment_bucket_id
key = "${var.name}/${local.deploy_artifact_key}"
source = var.path
etag = md5(local.source_hash)
tags = merge(var.tags, {
GitSHA = var.git_sha
})
Expand All @@ -78,8 +78,8 @@ resource "aws_lambda_function" "lambda" {
runtime = var.runtime
package_type = var.image_uri == null ? "Zip" : "Image"
s3_bucket = var.image_uri == null ? local.deployment_bucket_id : null
s3_key = var.image_uri == null ? aws_s3_bucket_object.lambda_deploy_object[0].key : null
s3_object_version = var.image_uri == null ? aws_s3_bucket_object.lambda_deploy_object[0].version_id : null
s3_key = var.image_uri == null ? aws_s3_object.lambda_deploy_object[0].key : null
s3_object_version = var.image_uri == null ? aws_s3_object.lambda_deploy_object[0].version_id : null
image_uri = var.image_uri
tags = var.tags
timeout = var.timeout
Expand Down
Loading