Skip to content

HHH-20006 uniqueElement() did not have a self-consistent definition of "same" #11470

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
gavinking wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −13
Open

HHH-20006 uniqueElement() did not have a self-consistent definition of "same" #11470

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 5 additions & 13 deletions hibernate-core/src/main/java/org/hibernate/query/spi/AbstractSelectionQuery.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -304,19 +304,11 @@ public R getSingleResult() {

protected static <T> T uniqueElement(List<T> list) throws NonUniqueResultException {
final int size = list.size();
if ( size == 0 ) {
return null;
}
else {
final T first = list.get( 0 );
// todo (6.0) : add a setting here to control whether to perform this validation or not
for ( int i = 1; i < size; i++ ) {
if ( list.get( i ) != first ) {
throw new NonUniqueResultException( list.size() );
}
}
return first;
}
return switch ( size ) {
case 0 -> null;
case 1 -> list.get( 0 );
default -> throw new NonUniqueResultException( size );
};
}

@Override
Expand Down
Loading