Repository navigation
Only require GitHub, OAuth and S3 settings on the master - #314
Merged
Merged
Conversation
The agents run the build jobs, which upload to S3 with the aws CLI and its AWS_* variables and never call GitHub, the OAuth flow or ExAws. Those settings were read with fetch_env! on every node, so the agents had to be given the master's GitHub token, OAuth client secret and S3 key to boot. They are now read only when BOB_WHO is master.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The agents run only the build jobs: they upload OTP builds with the aws CLI and its
AWS_*variables, push and sign images, and report back with the agent secret. GitHub (the checkers), ExAws (the S3 store) and the OAuth login run only on the master, butconfig/runtime.exsread their settings withfetch_env!on every node. That meant the agents had to be given the master's GitHub token, OAuth client secret and S3 key just to boot. Those settings are now read only whenBOB_WHOismaster, so hexpm/hexpm-ops can give the agents a separate, smaller secret.Checked by evaluating
config/runtime.exswithConfig.ReaderandMIX_ENV=prod. It now boots with the agent variables alone, and a master withoutBOB_GITHUB_USERstill raises.