Conversation
…cycle detection (2.1.0)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Hardens the reactivity core to close four real correctness gaps surfaced by a deep audit:
rerunPendingflag, with a 100-iteration safety cap to bail loudly on true cycles.derived(): conditional getters like() => flag() ? a() : b()no longer keep both branches' signals subscribed forever.retrack()now tags each dep edge with a per-evaluation epoch and unsubscribes stale edges at end of run.notifySubscribersused to diverge on whether cross-writing effects could re-run; unified into a single drain with dedup-cleared-before-invoke so sibling effects reliably converge on consistent state.setMaxSubscriberRepeats(n).Also: empty
__ssubscriber sets are now released,subscriberStackshrinks when idle, and__f/__sfast-path bookkeeping is centralized in asyncFastPath()helper.Internal
_depsstorage migrated fromSet<signal>toMap<signal, epoch>to carry the epoch tags. Public API is unchanged; devtoolsintrospect.getDependencies()updated for the new layout.201/201 test files, 2187/2187 tests passing. No behavior changes to user code that was already correct.
Related Issue
Closes #
Type of Change
Checklist