Merged
Conversation
…t disable comments (v1.2.0) - Fix bindChildNode identity-aware reconciliation: reused nodes are no longer removed and re-inserted, preventing DOM corruption when reactive nodes functions return the same HTMLElement instance across re-evaluations - Fix tagFactory boolean attribute handling: false now calls removeAttribute() instead of being silently skipped; IDL properties (checked, disabled, selected) set as DOM properties directly, matching bindAttribute behavior - Add inline disable comments for no-direct-dom-mutation lint rule: // sibujs-disable-next-line and // sibujs-disable on same line - Bump version to 1.2.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix three framework-level issues discovered during NESForge development and bump to v1.2.0.
Reconciler (bindChildNode.ts): Returning the same HTMLElement instance from a reactive
nodesfunction across re-evaluations caused DOM corruption (duplicates/disappearing elements). The reconciler now performs identity-aware reconciliation — reused nodes are kept in the DOM and only repositioned if needed.Boolean attributes (tagFactory.ts): Passing
falsefor an attribute (e.g.,textarea({ spellcheck: false })) was silently skipped instead of removing the attribute. Boolean handling now matchesbindAttributebehavior:truesets empty attribute,falsecallsremoveAttribute(), IDL properties (checked,disabled,selected) are set as DOM properties directly.Lint inline disable (linting.ts, lint.ts): The
no-direct-dom-mutationrule had no escape hatch. Added// sibujs-disable-next-lineand// sibujs-disableinline comment support to both the build-system and CLI linters.Also updated:
sibujs ^1.2.0,sibujs-cli ^1.2.0,sibujs-ui ^1.0.11)Related Issue
Closes #
Type of Change
Checklist